chore(ci): bump protoc version #8025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
|
✅ This change can build |
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
chris-olszewski
changed the title
mehulkar
approved these changes
Apr 23, 2024
chris-olszewski
force-pushed
the
olszewski/fix_protoc_macos_version
branch
from
d9cd9a1
to
78643d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumping
setup-protocto version 2 as it supports fetching MacOSarm64builds which are required formacos-latestnow that it runs on an M1 chip.Bumping
protocfrom3.20to3.26as3.20didn't have builds available for MacOS arm64.Note: Starting with 3.21 the protobuf project has switched it's versioning scheme so the major version 3 is implied.
setup-protocmatches this as of 2.0.0 so we specify version with the format ofMINOR.PATCH.We cannot update to
setup-protocto 3.0 as it uses Node20 which requires too high of glibc version for us to support our x86 musl builds.Testing Instructions
CI Passes
Verify that library release is able to build on arm64 machines: https://github.com/vercel/turbo/actions/runs/8806177110/job/24170410394
Dry run of release process: https://github.com/vercel/turbo/actions/runs/8807124431
Closes TURBO-2863