Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): pin Github Actions runner that builds turborepo to macos-12 #8024

Merged
merged 5 commits into from
Apr 23, 2024

Conversation

mehulkar
Copy link
Contributor

@mehulkar mehulkar commented Apr 23, 2024

macos-14 appears to not be able to build turborepo successfully
and macos-latest was recently updated to point to macos-14.
Pinning this until we figure out how to make macos-14 work

I didn't change JS package tests or turbopack related things
Closes TURBO-2862

macos-14 appears to not be able to build turborepo successfully
and macos-latest was recently updated to point to macos-14.
Pinning this until we figure out how to make macos-14 work
Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 6:22pm
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 6:22pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 6:22pm
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 6:22pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 6:22pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 6:22pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 6:22pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 6:22pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 6:22pm
rust-docs ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 6:22pm

Copy link
Contributor

github-actions bot commented Apr 23, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Apr 23, 2024

✅ This change can build next-swc

@chris-olszewski
Copy link
Contributor

I didn't change JS package tests or turbopack related things

I think we need to update these as well as they all hit the setup-rust action which installs protoc

Copy link
Contributor

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once CI passes, then :shipit:

@mehulkar
Copy link
Contributor Author

JS package tests shouldn't need to setup-rust, but yeah they do right now. replaced all the workflows now

Copy link
Contributor

github-actions bot commented Apr 23, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@mehulkar mehulkar merged commit ab004db into main Apr 23, 2024
56 of 58 checks passed
@mehulkar mehulkar deleted the mk/macos branch April 23, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants