Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove escaping of ! in filter argument to turbo run #5003

Merged
merged 1 commit into from May 17, 2023

Conversation

mehulkar
Copy link
Contributor

@mehulkar mehulkar commented May 17, 2023

I needed this locally and thought i needed it in CI also, but turns out the filter doesn't work with the escaping

@vercel
Copy link

vercel bot commented May 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2023 5:31pm
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) May 17, 2023 5:31pm
examples-cra-web ⬜️ Ignored (Inspect) May 17, 2023 5:31pm
examples-designsystem-docs ⬜️ Ignored (Inspect) May 17, 2023 5:31pm
examples-gatsby-web ⬜️ Ignored (Inspect) May 17, 2023 5:31pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) May 17, 2023 5:31pm
examples-native-web ⬜️ Ignored (Inspect) May 17, 2023 5:31pm
examples-nonmonorepo ⬜️ Ignored (Inspect) May 17, 2023 5:31pm
examples-svelte-web ⬜️ Ignored (Inspect) May 17, 2023 5:31pm
examples-tailwind-web ⬜️ Ignored (Inspect) May 17, 2023 5:31pm
examples-vite-web ⬜️ Ignored (Inspect) May 17, 2023 5:31pm

@github-actions
Copy link
Contributor

✅ This change can build next-swc

@mehulkar mehulkar marked this pull request as ready for review May 17, 2023 17:36
@mehulkar mehulkar requested review from a team as code owners May 17, 2023 17:36
@mehulkar mehulkar enabled auto-merge (squash) May 17, 2023 17:39
@mehulkar mehulkar disabled auto-merge May 17, 2023 17:52
@github-actions
Copy link
Contributor

Linux Benchmark for 349be6f

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9123.78µs ± 80.45µs 9159.60µs ± 61.74µs +0.39%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8391.30µs ± 40.61µs 8375.05µs ± 203.89µs -0.19%
bench_startup/Turbopack CSR/1000 modules 896.54ms ± 3.60ms 899.48ms ± 5.16ms +0.33%

@mehulkar mehulkar merged commit 38380d6 into main May 17, 2023
68 of 70 checks passed
@mehulkar mehulkar deleted the mk/exclude-correctly branch May 17, 2023 17:52
@github-actions
Copy link
Contributor

MacOS Benchmark for 349be6f

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 26.03ms ± 0.09ms 21.52ms ± 0.63ms -17.30% -11.86%
bench_hmr_to_eval/Turbopack CSR/1000 modules 25.23ms ± 0.35ms 38.50ms ± 5.48ms +52.63% +6.21%
bench_startup/Turbopack CSR/1000 modules 5486.88ms ± 906.59ms 3147.03ms ± 90.51ms -42.64% -9.41%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 26.03ms ± 0.09ms 21.52ms ± 0.63ms -17.30% -11.86%
bench_hmr_to_eval/Turbopack CSR/1000 modules 25.23ms ± 0.35ms 38.50ms ± 5.48ms +52.63% +6.21%
bench_startup/Turbopack CSR/1000 modules 5486.88ms ± 906.59ms 3147.03ms ± 90.51ms -42.64% -9.41%

@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)
  • Turbopack Rust benchmark tests (linux)

See workflow summary for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants