fix(turborepo): Use which crate to resolve yarn binary #5001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
NicholasLYang
force-pushed
the
fix/windows-find-program
branch
from
4f0d37a
to
67e58e6
Compare
mehulkar
approved these changes
May 17, 2023
Closed
🟢 CI successful 🟢Thanks |
gsoltis
requested changes
May 17, 2023
| @@ -76,7 +77,8 @@ fn execute_git_command( | |||
| args: &[&str], | |||
| pathspec: &str, | |||
| ) -> Result<Vec<u8>, Error> { | |||
| let mut command = Command::new("git"); | |||
| let git_binary = which("git")?; | |||
There was a problem hiding this comment.
We're going to use git a lot. We should perhaps memoize this and make it easy to use. Can do in a follow-up though.
| @@ -36,3 +36,48 @@ Set package manager to pnpm in package.json | |||
| Run test run | |||
| $ ${TURBO} run build --__test-run | jq .package_manager | |||
| "pnpm" | |||
|
|
|||
| Clear package manager field in package.json | |||
There was a problem hiding this comment.
We need to verify this manually on windows, these tests don't run there
gsoltis
approved these changes
May 17, 2023
NicholasLYang
force-pushed
the
fix/windows-find-program
branch
from
97134bd
to
2631b61
Compare
gsoltis
reviewed
May 17, 2023
Cargo.toml
Outdated
| @@ -197,3 +197,4 @@ tracing-subscriber = "0.3.16" | |||
| url = "2.2.2" | |||
| urlencoding = "2.1.2" | |||
| webbrowser = "0.8.7" | |||
| which = "4.4.0" | |||
There was a problem hiding this comment.
I think the lack of a newline here is hitting the linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4940 by using
whichcrate to resolve yarn binary. That way we use the correct extension, i.e.yarn.cmdon Windows.Testing Instructions
Tested manually on Windows. Will add more integration tests