Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text decoration line display inconsistencies. #530

Closed
LuciNyan opened this issue Aug 13, 2023 · 1 comment · Fixed by #531
Closed

Text decoration line display inconsistencies. #530

LuciNyan opened this issue Aug 13, 2023 · 1 comment · Fixed by #531
Labels
released

Comments

@LuciNyan
Copy link
Contributor

Bug report

Description / Observed Behavior

image image
  1. Text decoration lines not rendering when textDecorationColor is unset.
  2. Incorrect positioning of text decoration lines

Expected Behavior

Ensure proper text decoration line rendering.

Reproduction

https://og-playground.vercel.app/?share=dVJLTsMwEL3KyAh1E0H4CEEESIiyqMQOJDbduPEkcXHsyp70Q1WJa3A9TsI4bdpSwcrj92Y8855nKXKnUGTiVunp0AIEWhi8Wy5jDFChLivKoHeWpse9ZA3OtKLqAFM6TIxcMFoYnHdojPvaY07aWeZyZ5radqw0urQDwjpECi2h76hxE0gXi0fHoI39f9Mjmb-X3jVWPTrjPPNHRVFsu3LVi_7ADC7O96C3jZarNG3R1Wpo72PQST8U_58qgFrO3zYmXKTpZI_5Y7Kbs4frfrpLIZxTH3PnZXTlWVsetMcF6A3Huzw2q31gVmnawnFogHZsgAGBchjs9-cXAc51oAQ0gcUpeqhkOIEBUzVYF0iaUufsgwcJrClHoEp2uW0tqpPWjVO2gxusT5EIN4lzBpEtRfvzIrtmB8V6NUR2GS8KR00pskKagInA2o3162IS94pm7Y3fiX_wVI9QiYx8g6tEkBxxRoXGuJnzRonVDw

https://og-playground.vercel.app/?share=dVLLTuswEP2Vka-uuom44YIQRICEKItK7EBiw8aNJ4nBsSt7QluqSnwAP8CODX8BP4NgzS8wTgmU1yrjc-Z1TmYmcqdQZGJb6YtTCxBoanBnNosxQIW6rCiD3mqa_u0lC3CsFVVfMKXDyMgpo4XBSYfGuK895qSdZS53pqltx0qjSzsgrEOk0BL6jjprAuliuu8YtHH-Z3oo8_PSu8aqfWecZ_5PURTvU7nqSF9iBmv_l6CTNy0badqi8_mp3Y1BJ_2r-N9UAdRycvJmwlqajpaYHzbbWt3b7KcfKYQT6mPuvIyuHGrLi_a4AL3h-Le8rt240rSUxI5-h6MygFYbwIBAOQz28eqGACc6UAKawOIFeqhkWIGnh9vnu4eX--sB59RgXSBpSp2zax4ksAM5AlWyK2qboFppvfvH5vGkxVckwo3itkFkM9Heicg22W-xOCSRrceHwmFTiqyQJmAisHZn-ng6ildI4_bFfeIfO6iHqERGvsF5IkgOOaNCY9zYeaPE_BU

Additional Context

v0.13.0
@LuciNyan LuciNyan mentioned this issue Aug 13, 2023
Merged
shuding pushed a commit that referenced this issue Aug 31, 2023
@LuciNyan
fix: text decoration line (#531)
c47e1a9 
### Description
1. Default to the current color when `textDecorationColor` is unset.
2. Resolve incorrect positioning of decoration line.
3. Address inaccurate line-through positioning.

<img width="1438" alt="image"
src="https://github.com/vercel/satori/assets/22126563/71e401e1-f03d-45e4-a5ad-c202487ad605">

<img width="912" alt="image"
src="https://github.com/vercel/satori/assets/22126563/fe010957-ce7c-401d-bf02-e59e1a03a2a9">

Closes: #530
@github-actions
Copy link

🎉 This issue has been resolved in version 0.10.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

sahithyandev pushed a commit to sahithyandev/satori that referenced this issue Apr 26, 2024
@LuciNyan @sahithyandev
fix: text decoration line (vercel#531)
9e6dea7 
### Description
1. Default to the current color when `textDecorationColor` is unset.
2. Resolve incorrect positioning of decoration line.
3. Address inaccurate line-through positioning.

<img width="1438" alt="image"
src="https://github.com/vercel/satori/assets/22126563/71e401e1-f03d-45e4-a5ad-c202487ad605">

<img width="912" alt="image"
src="https://github.com/vercel/satori/assets/22126563/fe010957-ce7c-401d-bf02-e59e1a03a2a9">

Closes: vercel#530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: text decoration line LuciNyan/satori
1 participant
@LuciNyan