Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support mask-image, mask-size, mask-position, mask-repeat #495

Merged
merged 10 commits into from
Jun 3, 2023

Conversation

Jackie1210
Copy link
Contributor

@Jackie1210 Jackie1210 commented May 27, 2023

Features

  • mask-image: linear-gradient, radial-gradient, url() , linear-gradient(), url() no matter single or multiple value split by comma
  • mask-size
  • mask-position
  • mask-repeat

Partially resolve #244

You can preview it

Note

image(...) currently is css4 and is not support in any browser, so maybe we should impl it in another PR.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…peat
@Jackie1210 Jackie1210 requested a review from shuding as a code owner May 27, 2023 15:25
@vercel
Copy link

vercel bot commented May 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
satori-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2023 8:55am

@Jackie1210 Jackie1210 changed the title feat: support mask-image partially, mask-size, mask-position, mask-repeat feat: support mask-image, mask-size, mask-position, mask-repeat May 28, 2023
@Jackie1210 Jackie1210 changed the title feat: support mask-image, mask-size, mask-position, mask-repeat wip: support mask-image, mask-size, mask-position, mask-repeat May 29, 2023
@Jackie1210 Jackie1210 marked this pull request as draft May 29, 2023 13:39
@Jackie1210 Jackie1210 changed the title wip: support mask-image, mask-size, mask-position, mask-repeat feat: support mask-image, mask-size, mask-position, mask-repeat Jun 1, 2023
@Jackie1210 Jackie1210 marked this pull request as ready for review June 1, 2023 08:44
@Jackie1210
Copy link
Contributor Author

@shuding This PR is ready to review, thanks!

@Jackie1210 Jackie1210 changed the title feat: support mask-image, mask-size, mask-position, mask-repeat feat: support mask-image, mask-size, mask-position, mask-repeat Jun 1, 2023
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible work, thank you!

@shuding shuding merged commit 36a25ea into vercel:main Jun 3, 2023
@github-actions
Copy link

github-actions bot commented Jun 3, 2023

🎉 This PR is included in version 0.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Jackie1210 Jackie1210 deleted the feat/mask-image branch June 3, 2023 14:34
sahithyandev pushed a commit to sahithyandev/satori that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support CSS Mask Image?
2 participants