Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linear gradients work different from CSS references #440

Closed
SilentDepth opened this issue Apr 9, 2023 · 1 comment · Fixed by #448
Closed

Linear gradients work different from CSS references #440

SilentDepth opened this issue Apr 9, 2023 · 1 comment · Fixed by #448
Labels
bug Something isn't working released
Milestone
1.0

Comments

@SilentDepth
Copy link

Bug report

Description / Observed Behavior

The behavior of linear gradient is different from CSS-rendered results with some angles.

For example, linear-gradient(-45deg, crimson 50%, goldenrod 50%) renders the diagonal perfectly with CSS, but very off with Satori. However, with an angle of 45deg everything works fine.

Satori CSS
PixelSnap 2023-04-09 at 21 43 18 PixelSnap 2023-04-09 at 21 43 34

Expected Behavior

The render results of Satori and CSS should be identical.

Reproduction

Satori
CSS

Additional Context

Satori v0.4.7
@shuding shuding added the bug Something isn't working label Apr 9, 2023
@shuding shuding added this to the 1.0 milestone Apr 14, 2023
@shuding shuding mentioned this issue Apr 16, 2023
Merged
shuding added a commit that referenced this issue Apr 16, 2023
@shuding
fix: Correct linear gradient calculation (#448)
25a8e20 
Closes #440, closes #163.
@github-actions
Copy link

🎉 This issue has been resolved in version 0.4.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

sahithyandev pushed a commit to sahithyandev/satori that referenced this issue Apr 26, 2024
@shuding @sahithyandev
fix: Correct linear gradient calculation (vercel#448)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
98049b0 
Closes vercel#440, closes vercel#163.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

fix: Correct linear gradient calculation vercel/satori
2 participants
@shuding @SilentDepth