Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Non-breaking space #293

Closed
tvler opened this issue Nov 8, 2022 · 3 comments · Fixed by #359
Closed

Support Non-breaking space #293

tvler opened this issue Nov 8, 2022 · 3 comments · Fixed by #359
Labels
enhancement New feature or request released

Comments

@tvler
Copy link

tvler commented Nov 8, 2022

Feature Request

Description

Allow <span>Word1 Word2&nbsp;Word3</span> to work as expected: Carries down both Word2 and Word3 to a new line if needed

Additional Context

Example of non breaking space not working: https://og-playground.vercel.app/?share=nZBPS8QwEMW_ShiRvRQ2_kEk1AVRwbvCXnJpm2kbTTOlTV1rzHc36boie9xc8ub3mGHmeahIIQjIlf6QlrHRzQbvvE-asRZ10zrBVhecn6-yPdxp5dojpvTYm2KOtDb4eaBJP-oBK6fJRq8iM3X24JZF9d4MNFn1QIaG6J_Vdf3XS9a96C8U7OryH9r-bnTD-UJDkHaTRD72hd14Cd8nvGc0hqScOL_nWxqMkhDy9TJR2nwds4k_ZEB9umQE4WFJAcRt3AP2MYG4ToXCcmpA1IUZMQPs6E2_zn3K2O2WKs5Jlzx1JSoQbpgwhB8

Thank you for releasing such an excellent open source library!
@shuding shuding added the enhancement New feature or request label Nov 21, 2022
@sahithyandev
Copy link
Contributor

I gave it a quick look, and hope I am on the right track. I have made a WIP PR.

@sahithyandev sahithyandev mentioned this issue Jan 8, 2023
Merged
@sahithyandev
Copy link
Contributor

As #362 is closed as a wontfix. Support for &nbsp; won't be added.

To use a non breaking space, you would have to use the unicode   or \u0a00.
In my PR, the non breaking space character seem to work. But I am not totally sure about its behavior.

shuding added a commit that referenced this issue Apr 17, 2023
@sahithyandev @shuding
fix: Add support for non-breaking space (#359)
44f4a6b 
fixes #293.

---------

Co-authored-by: Shu Ding <g@shud.in>
@github-actions
Copy link

🎉 This issue has been resolved in version 0.4.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

sahithyandev added a commit to sahithyandev/satori that referenced this issue Apr 26, 2024
@sahithyandev @shuding
fix: Add support for non-breaking space (vercel#359)
b0ca0e4 
fixes vercel#293.

---------

Co-authored-by: Shu Ding <g@shud.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add support for non-breaking space sahithyandev/satori
3 participants
@shuding @tvler @sahithyandev