Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] middleware subrequest patch #77418

Merged
merged 8 commits into from
Mar 22, 2025
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Mar 22, 2025

Same as #77202 but for v13 release branch

@ijjk ijjk added the Font (next/font) Related to Next.js Font Optimization. label Mar 22, 2025
ijjk added 6 commits March 22, 2025 11:16
@ijjk
Copy link
Member Author

ijjk commented Mar 22, 2025

Failing test suites

Commit: 1ad49fd

pnpm test test/integration/create-next-app/index.test.ts (turbopack)

  • create next app > valid example
  • create next app > should allow example with GitHub URL
  • create next app > should allow example with GitHub URL and example-path
  • create next app > should use --example-path over the file path in the GitHub URL
Expand output

● create next app › valid example

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  81 |   for (const file of files) {
  82 |     try {
> 83 |       expect(existsSync(resolve(projectRoot, file))).toBe(true)
     |                                                      ^
  84 |     } catch (err) {
  85 |       require('console').error(
  86 |         `missing expected file ${file}`,

  at projectFilesShouldExist (integration/create-next-app/lib/utils.ts:83:54)
  at integration/create-next-app/index.test.ts:131:30
  at useTempDir (lib/use-temp-dir.ts:24:5)
  at Object.<anonymous> (integration/create-next-app/index.test.ts:115:5)

● create next app › should allow example with GitHub URL

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  81 |   for (const file of files) {
  82 |     try {
> 83 |       expect(existsSync(resolve(projectRoot, file))).toBe(true)
     |                                                      ^
  84 |     } catch (err) {
  85 |       require('console').error(
  86 |         `missing expected file ${file}`,

  at projectFilesShouldExist (integration/create-next-app/lib/utils.ts:83:54)
  at integration/create-next-app/index.test.ts:188:30
  at useTempDir (lib/use-temp-dir.ts:24:5)
  at Object.<anonymous> (integration/create-next-app/index.test.ts:171:5)

● create next app › should allow example with GitHub URL and example-path

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  81 |   for (const file of files) {
  82 |     try {
> 83 |       expect(existsSync(resolve(projectRoot, file))).toBe(true)
     |                                                      ^
  84 |     } catch (err) {
  85 |       require('console').error(
  86 |         `missing expected file ${file}`,

  at projectFilesShouldExist (integration/create-next-app/lib/utils.ts:83:54)
  at integration/create-next-app/index.test.ts:252:30
  at useTempDir (lib/use-temp-dir.ts:24:5)
  at Object.<anonymous> (integration/create-next-app/index.test.ts:233:5)

● create next app › should use --example-path over the file path in the GitHub URL

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  81 |   for (const file of files) {
  82 |     try {
> 83 |       expect(existsSync(resolve(projectRoot, file))).toBe(true)
     |                                                      ^
  84 |     } catch (err) {
  85 |       require('console').error(
  86 |         `missing expected file ${file}`,

  at projectFilesShouldExist (integration/create-next-app/lib/utils.ts:83:54)
  at integration/create-next-app/index.test.ts:285:30
  at useTempDir (lib/use-temp-dir.ts:24:5)
  at Object.<anonymous> (integration/create-next-app/index.test.ts:266:5)

Read more about building and testing Next.js in contributing.md.

@ijjk ijjk marked this pull request as ready for review March 22, 2025 19:04
@ijjk ijjk requested review from delbaoliveira and nicoalbanese and removed request for a team March 22, 2025 19:04
@ijjk ijjk merged commit 0a49ce1 into next-13 Mar 22, 2025
32 of 55 checks passed
@ijjk ijjk deleted the ijjk/v13-apply-middleware-patch branch March 22, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Next.js team PRs by the Next.js team. Font (next/font) Related to Next.js Font Optimization. tests type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants