Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Turbopack] avoid crashing on e.g. .DS_Store #75050

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 17, 2025

What?

Accept unexpected files in the persistent cache data directory

Closes PACK-3765

Verified

This commit was signed with the committer’s verified signature.
Wauplin Lucain
@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Jan 17, 2025
Copy link
Member Author

sokra commented Jan 17, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sokra sokra changed the title avoid crashing on e.g. .DS_Store [Turbopack] avoid crashing on e.g. .DS_Store Jan 17, 2025
@ijjk
Copy link
Member

ijjk commented Jan 17, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sokra/persistent-caching-fixes Change
buildDuration 18s 16.1s N/A
buildDurationCached 15.3s 13s N/A
nodeModulesSize 418 MB 418 MB
nextStartRea..uration (ms) 409ms 432ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/persistent-caching-fixes Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.4 kB 34.4 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 52.9 kB 52.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/persistent-caching-fixes Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/persistent-caching-fixes Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/persistent-caching-fixes Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/persistent-caching-fixes Change
index.html gzip 524 B 524 B
link.html gzip 538 B 538 B
withRouter.html gzip 519 B 521 B N/A
Overall change 1.06 kB 1.06 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/persistent-caching-fixes Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 208 kB 208 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sokra/persistent-caching-fixes Change
middleware-b..fest.js gzip 669 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js sokra/persistent-caching-fixes Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 374 kB 374 kB
app-page-exp..prod.js gzip 130 kB 130 kB
app-page-tur..prod.js gzip 143 kB 143 kB
app-page-tur..prod.js gzip 139 kB 139 kB
app-page.run...dev.js gzip 362 kB 362 kB
app-page.run..prod.js gzip 126 kB 126 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 27.7 kB 27.7 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.47 MB 2.47 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/persistent-caching-fixes Change
0.pack gzip 2.09 MB 2.1 MB ⚠️ +4.04 kB
index.pack gzip 74.3 kB 75.3 kB ⚠️ +1.02 kB
Overall change 2.17 MB 2.17 MB ⚠️ +5.06 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 73185cb

@sokra sokra marked this pull request as ready for review January 17, 2025 20:33
@sokra sokra requested a review from bgw January 17, 2025 20:33
@sokra sokra merged commit 9e8d6bc into canary Jan 17, 2025
132 checks passed
Copy link
Member Author

sokra commented Jan 17, 2025

Merge activity

  • Jan 17, 3:55 PM EST: A user merged this pull request with Graphite.

@sokra sokra deleted the sokra/persistent-caching-fixes branch January 17, 2025 20:55
Copy link
Member

@bgw bgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be broadened even further to just ignore any files that don't end with .sst or .blob.

Windows could create some hidden files that don't start with '.'

@github-actions github-actions bot added the locked label Feb 1, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants