fix: update broken links in config-shared.d.ts #74122
Merged
+23
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ijjk , could you review this pr? |
ijjk
approved these changes
Jan 2, 2025
|
@ijjk Thank you |
jophy-ye
reviewed
Jan 4, 2025
| @@ -703,22 +703,22 @@ export interface NextConfig extends Record<string, any> { | |||
| /** | |||
There was a problem hiding this comment.
@yongholeeme Wow thank you. I spotted this error several weeks ago and always intended to fix it in a PR, but you got it in earlier haha! The URL on Moment.js on line 699 still appears to be incorrect, although not broken.🤔 However, I couldn't trace the page down...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links beginning with
"https://nextjs.org/docs/api-reference/next.config.js"are broken in https://github.com/vercel/next.js/blob/canary/packages/next/src/server/config-shared.ts#L616.And I found other broken links with same problems and fixed those. 09ff492
close #74121