Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Started docs: Fetching and Streaming #73352

Merged
merged 17 commits into from
Dec 3, 2024

Conversation

delbaoliveira
Copy link
Contributor

@delbaoliveira delbaoliveira commented Nov 29, 2024

Verified

This commit was signed with the committer’s verified signature. The key has expired.
danielleadams Danielle Adams

Verified

This commit was signed with the committer’s verified signature. The key has expired.
danielleadams Danielle Adams

Verified

This commit was signed with the committer’s verified signature.
ruyadorno Ruy Adorno

Verified

This commit was signed with the committer’s verified signature.
ruyadorno Ruy Adorno
@ijjk ijjk added created-by: Next.js DevEx team PRs by the DX team. Documentation Related to Next.js' official documentation. labels Nov 29, 2024
Copy link
Contributor

github-actions bot commented Nov 29, 2024

All broken links are now fixed, thank you!

Verified

This commit was signed with the committer’s verified signature.
ruyadorno Ruy Adorno

Verified

This commit was signed with the committer’s verified signature.
ruyadorno Ruy Adorno

Verified

This commit was signed with the committer’s verified signature.
ruyadorno Ruy Adorno
- Co-pilot doing me dirty again
@delbaoliveira delbaoliveira marked this pull request as ready for review November 29, 2024 16:20
Copy link
Collaborator

@molebox molebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small comments

delbaoliveira and others added 4 commits December 2, 2024 10:21

Unverified

This user has not yet uploaded their public signing key.
Co-authored-by: Rich Haines <hello@richardhaines.dev>

Unverified

This user has not yet uploaded their public signing key.

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso

> **Warning:** The content below assumes the [`dynamicIO` config option](/docs/app/api-reference/config/next-config-js/dynamicIO) is enabled in your application. The flag was introduced in Next.js 15 canary.
When using `async/await` in Server Components, Next.js will opt into **dynamic rendering**. This means the data will be fetched and rendered on the server for every user request. If there are any slow data requests, the whole route will be blocked from rendering. To improve the initial load time and user experience, you can use streaming to break up the page's HTML into smaller chunks and progressively send those chunks from the server to the client.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we clarify that Next.js streams by default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, what do you mean?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph reads like you need to opt-into streaming. But the App Router will stream by default, it's just how much content is included in the initial payload depends on your suspense boundaries. That's my understanding (which could be wrong!). Basically what I'm saying it, you can't turn streaming off, and you don't need to enable it.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
@leerob leerob merged commit 14a5fd8 into canary Dec 3, 2024
52 checks passed
@leerob leerob deleted the docs-getting-started-fetching-data branch December 3, 2024 20:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js DevEx team PRs by the DX team. Documentation Related to Next.js' official documentation. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants