Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Started Docs: CSS #73341

Merged
merged 30 commits into from
Dec 3, 2024
Merged

Getting Started Docs: CSS #73341

merged 30 commits into from
Dec 3, 2024

Conversation

delbaoliveira
Copy link
Contributor

@delbaoliveira delbaoliveira commented Nov 29, 2024

@ijjk ijjk added created-by: Next.js DevEx team PRs by the DX team. Documentation Related to Next.js' official documentation. Font (next/font) Related to Next.js Font Optimization. labels Nov 29, 2024
Copy link
Contributor

github-actions bot commented Nov 29, 2024

All broken links are now fixed, thank you!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…next.js into docs-getting-started-css
@delbaoliveira delbaoliveira marked this pull request as ready for review November 29, 2024 13:40
molebox
molebox previously requested changes Dec 2, 2024
delbaoliveira and others added 2 commits December 2, 2024 10:25

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Rich Haines <hello@richardhaines.dev>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@delbaoliveira
Copy link
Contributor Author

@leerob I'll apply the feedback above in a new PR since this one relates to CSS.

@leerob leerob merged commit f27ee7d into canary Dec 3, 2024
52 checks passed
@leerob leerob deleted the docs-getting-started-css branch December 3, 2024 20:04
- [`stylex`](https://stylexjs.com)
- [`tamagui`](https://tamagui.dev/docs/guides/next-js#server-components)
- [`tss-react`](https://tss-react.dev/)
- [`vanilla-extract`](https://vanilla-extract.style)
Copy link

@christiankaindl christiankaindl Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! We are using vanilla-extract in Server Components since quite some time, so I not sure the warning that it only works in Client Components is accurate. vanilla-extract uses a plugin that generates static CSS and classNames just like CSS Modules (but uses TypeScript for generating the stylesheet), what would not work in Server Components?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js DevEx team PRs by the DX team. Documentation Related to Next.js' official documentation. Font (next/font) Related to Next.js Font Optimization. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants