Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add note about remove of the swcMinify flag #73281

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

icyJoseph
Copy link
Contributor

@icyJoseph icyJoseph commented Nov 27, 2024

What?

Docs update.

As noted in, #73267, swcMinify, is still listed in the documentation, though the flag has been removed.

Why?

The flag has been removed.

How?

Add a note, for reference, that the flag has been removed, rather than dropping the entire Minification section.

I wonder, though, what is the recommended way to opt-out, and into Terser again, should you find an issue with SWC's minification? Hi-jacking the minifier in the Webpack config object?

Fixes #73267

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Nov 27, 2024
@ijjk
Copy link
Member

ijjk commented Nov 27, 2024

Allow CI Workflow Run

  • approve CI run for commit: 99ae423

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Sorry, something went wrong.

Copy link
Contributor

@delbaoliveira delbaoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @icyJoseph 🙏🏼

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@delbaoliveira delbaoliveira enabled auto-merge (squash) December 3, 2024 13:57
@delbaoliveira delbaoliveira merged commit 39bde00 into vercel:canary Dec 3, 2024
39 checks passed
AndreMiras added a commit to AndreMiras/edilkamin that referenced this pull request Dec 9, 2024
The error was:
```
Invalid next.config.js options detected:
    Unrecognized key(s) in object: 'swcMinify'
```

refs vercel/next.js#73281
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Related to Next.js' official documentation. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: NextJS compiler docs still list swcMinify config option
3 participants