Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: missing await when using params #73044

Merged
merged 1 commit into from
Nov 21, 2024
Merged

docs: missing await when using params #73044

merged 1 commit into from
Nov 21, 2024
+6 −1

Conversation

hyungjikim
Copy link
Contributor

Hi, Team.
I'm adding await when using params as it will cause build to fail.

Improving Documentation

@hyungjikim
fix: missing await when using params
Loading
Loading status checks…
0955feb
@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Nov 21, 2024
@ijjk
Copy link
Member

ijjk commented Nov 21, 2024 •
edited by eps1lon
Loading

Allow CI Workflow Run

  • approve CI run for commit: 0955feb

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Sorry, something went wrong.

@eps1lon eps1lon merged commit 58b993c into vercel:canary Nov 21, 2024
40 checks passed
@eps1lon
Copy link
Member

eps1lon commented Nov 21, 2024

Thank you

@hyungjikim hyungjikim mentioned this pull request Nov 21, 2024
Merged
wyattjoh pushed a commit that referenced this pull request Nov 28, 2024
@hyungjikim @wyattjoh
docs: missing await when using params (#73044)

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
eb76ff8
@github-actions github-actions bot added the locked label Dec 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eps1lon eps1lon

Assignees
No one assigned
Labels
Documentation Related to Next.js' official documentation. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hyungjikim @ijjk @eps1lon