Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: update app-dir-i18n-routing to v15 #72636

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

samcx
Copy link
Member

@samcx samcx commented Nov 12, 2024

Why?

The example app-dir-i18n-routing needs to be updated to v15.

How?

Run the next-async-request-api codemod:

pnpm dlx @next/codemod@latest next-async-request-api .

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. examples Issue was opened via the examples template. labels Nov 12, 2024
Copy link
Member Author

samcx commented Nov 12, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @samcx and the rest of your teammates on Graphite Graphite

@samcx samcx requested a review from gaojude November 12, 2024 22:27
@samcx samcx marked this pull request as ready for review November 12, 2024 22:28
@samcx samcx merged commit 151d07e into canary Nov 12, 2024
53 checks passed
@samcx samcx deleted the sam/examples/app-dir-i18n-routing branch November 12, 2024 22:29
samcx added a commit that referenced this pull request Nov 13, 2024
## Summary
Follow up #72636.
Bump 13 → 15 version in the description.

### Adding or Updating Examples

- [x] The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- [x] Make sure the linting passes by running `pnpm build && pnpm lint`.
See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

---------

Co-authored-by: samcx <sam@vercel.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app-dir-i18n-routing example does not currently pass type checking
3 participants