Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(data-fetching): fix static params as promise examples #72565

Merged
merged 3 commits into from
Nov 12, 2024
Merged

docs(data-fetching): fix static params as promise examples #72565

merged 3 commits into from
Nov 12, 2024
+13 −5

Conversation

devpla
Copy link
Contributor

@devpla devpla commented Nov 11, 2024 •
edited
Loading

Improving Documentation

  • Since the params prop is now a promise, the type of params in the generateMetadata and Page components has been changed from { id: string } to Promise<{ id: string }>.

@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Nov 11, 2024
@devpla devpla changed the title docs(data-fetching): fix static params as promise examples docs: fix static params as promise examples Nov 11, 2024
@ijjk
Copy link
Member

ijjk commented Nov 11, 2024

Allow CI Workflow Run

  • approve CI run for commit: 5bbe264

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Sorry, something went wrong.

@ijjk
Copy link
Member

ijjk commented Nov 11, 2024 •
edited
Loading

Allow CI Workflow Run

  • approve CI run for commit: d786742

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Sorry, something went wrong.

@devpla devpla changed the title docs: fix static params as promise examples docs: fix static params as promise examples (data fetching) Nov 11, 2024
@devpla devpla changed the title docs: fix static params as promise examples (data fetching) docs(data fetching): fix static params as promise examples Nov 12, 2024
@devpla
docs: fix static params as promise examples

Verified

This commit was signed with the committer’s verified signature. The key has expired.
ewfian Fan
GPG key ID: 27FF0DE74F9B257A
Expired
Verified
Learn about vigilant mode
4bd35d4
@devpla
docs: remove types of js examples

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
d786742
@devpla devpla force-pushed the docs-static-params-promise branch from 846389d to d786742 Compare November 12, 2024 14:48
@devpla devpla changed the title docs(data fetching): fix static params as promise examples docs(data-fetching): fix static params as promise examples Nov 12, 2024
@ijjk ijjk enabled auto-merge (squash) November 12, 2024 21:09
@ijjk ijjk merged commit f705f9a into vercel:canary Nov 12, 2024
39 checks passed
@devpla devpla deleted the docs-static-params-promise branch November 14, 2024 13:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk

Assignees
No one assigned
Labels
Documentation Related to Next.js' official documentation. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devpla @ijjk