Skip to content

Fix more Turbopack build tests #64384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2024
Merged

Fix more Turbopack build tests #64384

merged 1 commit into from
Apr 12, 2024
+7 −4

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Apr 12, 2024 •
edited by padmaia
Loading

What?

  • Removes the node-file-trace options from being unsupported as they are passed to node-file-trace in build/index.ts
  • Ensures import next from 'next' is handled in the same way as webpack: creating an empty module. Currently it tried to bundle all Next.js internals which is wrong.

Closes NEXT-3086

@timneutkens
Fix more Turbopack build tests
Loading
Loading status checks…
fcbcdc1
@ijjk ijjk added Turbopack Related to Turbopack with Next.js. created-by: Next.js team PRs by the Next.js team. type: next labels Apr 12, 2024
@timneutkens Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @timneutkens and the rest of your teammates on Graphite Graphite

@ijjk
Copy link
Member

ijjk commented Apr 12, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js 04-12-Fix_more_Turbopack_build_tests Change
buildDuration 17.3s 17.1s N/A
buildDurationCached 10.8s 8.1s N/A
nodeModulesSize 199 MB 199 MB N/A
nextStartRea..uration (ms) 446ms 465ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 04-12-Fix_more_Turbopack_build_tests Change
2453-HASH.js gzip 31.4 kB 31.4 kB N/A
3304.HASH.js gzip 181 B 181 B ✓
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB ✓
8299-HASH.js gzip 5.1 kB 5.1 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 242 B 242 B ✓
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99.3 kB 99.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 04-12-Fix_more_Turbopack_build_tests Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js 04-12-Fix_more_Turbopack_build_tests Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B ✓
amp-HASH.js gzip 505 B 505 B ✓
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B ✓
head-HASH.js gzip 352 B 352 B ✓
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.27 kB 4.27 kB ✓
index-HASH.js gzip 259 B 259 B ✓
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 6.63 kB 6.63 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js 04-12-Fix_more_Turbopack_build_tests Change
_buildManifest.js gzip 483 B 485 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js 04-12-Fix_more_Turbopack_build_tests Change
index.html gzip 529 B 529 B ✓
link.html gzip 541 B 541 B ✓
withRouter.html gzip 525 B 524 B N/A
Overall change 1.07 kB 1.07 kB ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 04-12-Fix_more_Turbopack_build_tests Change
edge-ssr.js gzip 95.6 kB 95.6 kB N/A
page.js gzip 3.06 kB 3.06 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js 04-12-Fix_more_Turbopack_build_tests Change
middleware-b..fest.js gzip 624 B 625 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B ✓
Overall change 839 B 839 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js 04-12-Fix_more_Turbopack_build_tests Change
app-page-exp...dev.js gzip 171 kB 171 kB ✓
app-page-exp..prod.js gzip 97.4 kB 97.4 kB ✓
app-page-tur..prod.js gzip 99.2 kB 99.2 kB ✓
app-page-tur..prod.js gzip 93.4 kB 93.4 kB ✓
app-page.run...dev.js gzip 144 kB 144 kB ✓
app-page.run..prod.js gzip 91.9 kB 91.9 kB ✓
app-route-ex...dev.js gzip 21.4 kB 21.4 kB ✓
app-route-ex..prod.js gzip 15.2 kB 15.2 kB ✓
app-route-tu..prod.js gzip 15.2 kB 15.2 kB ✓
app-route-tu..prod.js gzip 14.9 kB 14.9 kB ✓
app-route.ru...dev.js gzip 21.1 kB 21.1 kB ✓
app-route.ru..prod.js gzip 14.9 kB 14.9 kB ✓
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB ✓
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB ✓
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB ✓
pages-turbo...prod.js gzip 22.5 kB 22.5 kB ✓
pages.runtim...dev.js gzip 23.1 kB 23.1 kB ✓
pages.runtim..prod.js gzip 22.5 kB 22.5 kB ✓
server.runti..prod.js gzip 51.3 kB 51.3 kB ✓
Overall change 948 kB 948 kB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 04-12-Fix_more_Turbopack_build_tests Change
0.pack gzip 1.58 MB 1.59 MB ⚠️ +346 B
index.pack gzip 107 kB 107 kB ⚠️ +400 B
Overall change 1.69 MB 1.69 MB ⚠️ +746 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: fcbcdc1

@ijjk
Copy link
Member

ijjk commented Apr 12, 2024 •
edited
Loading

Tests Passed

@timneutkens timneutkens merged commit c9c074c into canary Apr 12, 2024
79 checks passed
@timneutkens timneutkens deleted the 04-12-Fix_more_Turbopack_build_tests branch April 12, 2024 13:52
ztanner pushed a commit that referenced this pull request Apr 17, 2024
@timneutkens @ztanner
Fix more Turbopack build tests (#64384)
3a5bcc6 
## What?

- Removes the node-file-trace options from being unsupported as they are
passed to node-file-trace in build/index.ts
- Ensures `import next from 'next'` is handled in the same way as
webpack: creating an empty module. Currently it tried to bundle all
Next.js internals which is wrong.

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->


Closes NEXT-3086
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sokra sokra

@ijjk ijjk

@shuding shuding

@huozhi huozhi

@feedthejim feedthejim

@ztanner ztanner

@wyattjoh wyattjoh

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timneutkens @ijjk @sokra