Turbopack: Don’t show stack traces for internal modules #64228

wbinnssmith · 2024-04-08T21:57:23Z

See

next.js/packages/next/src/client/components/react-dev-overlay/server/shared.ts

Lines 59 to 62 in ac7607f

    
           /** 
        
            * It looks up the code frame of the traced source. 
        
            * @note It ignores node_modules or Next.js/React internals, as these can often be huge budnled files. 
        
            */

.

Test Plan: Added an e2e test.

Closes PACK-2919

See https://github.com/vercel/next.js/blob/ac7607f9775ea97bcb7f01f9da148d8c51abcc42/packages/next/src/client/components/react-dev-overlay/server/shared.ts#L59-L62. Test Plan: Added an e2e test.

ijjk · 2024-04-08T22:01:35Z

Tests Passed

ijjk · 2024-04-08T22:04:03Z

Stats from current PR

Default Build

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js wbinnssmith/internal-traces	Change
buildDuration	14s	14.2s	⚠️ +191ms
buildDurationCached	7.7s	6.8s	N/A
nodeModulesSize	199 MB	199 MB	⚠️ +4.23 kB
nextStartRea..uration (ms)	383ms	382ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js wbinnssmith/internal-traces	Change
2453-HASH.js gzip	31.5 kB	31.5 kB	N/A
3304.HASH.js gzip	181 B	181 B	✓
3f784ff6-HASH.js gzip	53.7 kB	53.7 kB	✓
8299-HASH.js gzip	5.1 kB	5.1 kB	N/A
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	242 B	242 B	✓
main-HASH.js gzip	29.6 kB	29.7 kB	N/A
webpack-HASH.js gzip	1.68 kB	1.68 kB	N/A
Overall change	99.3 kB	99.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js wbinnssmith/internal-traces	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js wbinnssmith/internal-traces	Change
_app-HASH.js gzip	196 B	197 B	N/A
_error-HASH.js gzip	184 B	184 B	✓
amp-HASH.js gzip	505 B	505 B	✓
css-HASH.js gzip	324 B	325 B	N/A
dynamic-HASH.js gzip	2.5 kB	2.5 kB	N/A
edge-ssr-HASH.js gzip	258 B	258 B	✓
head-HASH.js gzip	352 B	352 B	✓
hooks-HASH.js gzip	370 B	371 B	N/A
image-HASH.js gzip	4.27 kB	4.27 kB	✓
index-HASH.js gzip	259 B	259 B	✓
link-HASH.js gzip	2.67 kB	2.67 kB	N/A
routerDirect..HASH.js gzip	314 B	312 B	N/A
script-HASH.js gzip	386 B	386 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	6.63 kB	6.63 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js wbinnssmith/internal-traces	Change
_buildManifest.js gzip	483 B	485 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js wbinnssmith/internal-traces	Change
index.html gzip	528 B	527 B	N/A
link.html gzip	541 B	540 B	N/A
withRouter.html gzip	524 B	522 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js wbinnssmith/internal-traces	Change
edge-ssr.js gzip	94.4 kB	94.4 kB	N/A
page.js gzip	3.05 kB	3.05 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js wbinnssmith/internal-traces	Change
middleware-b..fest.js gzip	624 B	625 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	25.5 kB	25.5 kB	N/A
edge-runtime..pack.js gzip	839 B	839 B	✓
Overall change	839 B	839 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js wbinnssmith/internal-traces	Change
app-page-exp...dev.js gzip	171 kB	171 kB	✓
app-page-exp..prod.js gzip	97.5 kB	97.5 kB	✓
app-page-tur..prod.js gzip	99.2 kB	99.2 kB	✓
app-page-tur..prod.js gzip	93.5 kB	93.5 kB	✓
app-page.run...dev.js gzip	145 kB	145 kB	✓
app-page.run..prod.js gzip	92 kB	92 kB	✓
app-route-ex...dev.js gzip	21.5 kB	21.5 kB	✓
app-route-ex..prod.js gzip	15.2 kB	15.2 kB	✓
app-route-tu..prod.js gzip	15.2 kB	15.2 kB	✓
app-route-tu..prod.js gzip	14.9 kB	14.9 kB	✓
app-route.ru...dev.js gzip	21.1 kB	21.1 kB	✓
app-route.ru..prod.js gzip	14.9 kB	14.9 kB	✓
pages-api-tu..prod.js gzip	9.55 kB	9.55 kB	✓
pages-api.ru...dev.js gzip	9.82 kB	9.82 kB	✓
pages-api.ru..prod.js gzip	9.55 kB	9.55 kB	✓
pages-turbo...prod.js gzip	21.4 kB	21.4 kB	✓
pages.runtim...dev.js gzip	22.1 kB	22.1 kB	✓
pages.runtim..prod.js gzip	21.4 kB	21.4 kB	✓
server.runti..prod.js gzip	51.5 kB	51.5 kB	✓
Overall change	945 kB	945 kB	✓

build cache

	vercel/next.js canary	vercel/next.js wbinnssmith/internal-traces	Change
0.pack gzip	1.6 MB	1.59 MB	N/A
index.pack gzip	107 kB	107 kB	N/A
Overall change	0 B	0 B	✓

Diff details

Diff for middleware.js

Diff too large to display

Commit: 1623969

timneutkens · 2024-04-10T05:56:31Z

test/development/acceptance/ReactRefreshLogBox-builtins.test.ts

@@ -49,9 +49,6 @@ describe.each(['default', 'turbo'])('ReactRefreshLogBox %s', () => {
      expect(await session.getRedboxSource()).toMatchInlineSnapshot(`
        "./node_modules/my-package/index.js:1:13
        Module not found: Can't resolve 'dns'
-        > 1 | const dns = require('dns')


For node_modules the codeframe should still be shown, just not for ones that are very few lines and the individual line is thousands of characters.

This is consistent with webpack's behavior — should we change both?

…l-traces

kwonoj · 2024-04-17T01:22:03Z

test/development/acceptance/ReactRefreshLogBox-builtins.test.ts

@@ -11,7 +11,7 @@ describe.each(['default', 'turbo'])('ReactRefreshLogBox %s', () => {
  })

  // Module trace is only available with webpack 5
-  test('Node.js builtins', async () => {
+  test.only('Node.js builtins', async () => {


is this expected?

kwonoj · 2024-04-17T01:22:36Z

test/development/acceptance/ReactRefreshLogBox-builtins.test.ts

@@ -59,6 +59,9 @@ describe.each(['default', 'turbo'])('ReactRefreshLogBox %s', () => {
      expect(await session.getRedboxSource()).toMatchInlineSnapshot(`
        "./node_modules/my-package/index.js:1:1
        Module not found: Can't resolve 'dns'
+        > 1 | const dns = require('dns')


what's difference between https://github.com/vercel/next.js/pull/64228/files#diff-05b6ff60dd6730bcd70eb57fc3313401ed96c5e427468d2aa2758894541e2c98L57 one removes existing stack and one adds new?

This brings Next.js+Webpack in line with the Turbopack behavior, showing these frames (but not long bundled internal files)

Turbopack: Don’t show stack traces for internal modules

Loading
Loading status checks…

a119dbe

See https://github.com/vercel/next.js/blob/ac7607f9775ea97bcb7f01f9da148d8c51abcc42/packages/next/src/client/components/react-dev-overlay/server/shared.ts#L59-L62. Test Plan: Added an e2e test.

ijjk added area: tests created-by: Turbopack team type: next labels Apr 8, 2024

wbinnssmith added 3 commits April 8, 2024 15:51

fixup! Turbopack: Don’t show stack traces for internal modules

Loading
Loading status checks…

572edb3

fixup! Turbopack: Don’t show stack traces for internal modules

Loading
Loading status checks…

3242d45

fixup! Turbopack: Don’t show stack traces for internal modules

Loading
Loading status checks…

a9656fa

wbinnssmith marked this pull request as ready for review April 9, 2024 00:28

wbinnssmith requested review from timneutkens, ijjk, shuding, huozhi, feedthejim, ztanner and wyattjoh as code owners April 9, 2024 00:28

wbinnssmith requested review from kwonoj, sokra and bgw April 9, 2024 00:28

timneutkens reviewed Apr 10, 2024

View reviewed changes

wbinnssmith added 2 commits April 16, 2024 17:38

Merge remote-tracking branch 'origin/canary' into wbinnssmith/interna…

Loading
Loading status checks…

bb3f496

…l-traces

fixup! Turbopack: Don’t show stack traces for internal modules

7db6a27

wbinnssmith requested a review from a team as a code owner April 17, 2024 01:20

kwonoj reviewed Apr 17, 2024

View reviewed changes

wbinnssmith added 3 commits April 16, 2024 18:30

fixup! Turbopack: Don’t show stack traces for internal modules

f735398

fixup! Turbopack: Don’t show stack traces for internal modules

f873139

fixup! Turbopack: Don’t show stack traces for internal modules

1623969

wbinnssmith requested a review from timneutkens April 17, 2024 03:24

wbinnssmith requested a review from kwonoj April 17, 2024 03:24

bgw approved these changes Apr 17, 2024

View reviewed changes

wbinnssmith merged commit 61a0f09 into canary Apr 18, 2024
79 checks passed

wbinnssmith deleted the wbinnssmith/internal-traces branch April 18, 2024 23:56

github-actions bot added the locked label May 3, 2024

github-actions bot locked as resolved and limited conversation to collaborators May 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Turbopack: Don’t show stack traces for internal modules #64228

Turbopack: Don’t show stack traces for internal modules #64228

wbinnssmith commented Apr 8, 2024 •

edited by padmaia

Loading

ijjk commented Apr 8, 2024 •

edited

Loading

ijjk commented Apr 8, 2024 •

edited

Loading

timneutkens Apr 10, 2024

wbinnssmith Apr 10, 2024

kwonoj Apr 17, 2024

kwonoj Apr 17, 2024

wbinnssmith Apr 17, 2024

	/**
	* It looks up the code frame of the traced source.
	* @note It ignores node_modules or Next.js/React internals, as these can often be huge budnled files.
	*/

Turbopack: Don’t show stack traces for internal modules #64228

Turbopack: Don’t show stack traces for internal modules #64228

Conversation

wbinnssmith commented Apr 8, 2024 • edited by padmaia Loading

ijjk commented Apr 8, 2024 • edited Loading

Tests Passed

ijjk commented Apr 8, 2024 • edited Loading

Stats from current PR

timneutkens Apr 10, 2024

Choose a reason for hiding this comment

wbinnssmith Apr 10, 2024

Choose a reason for hiding this comment

kwonoj Apr 17, 2024

Choose a reason for hiding this comment

kwonoj Apr 17, 2024

Choose a reason for hiding this comment

wbinnssmith Apr 17, 2024

Choose a reason for hiding this comment

wbinnssmith commented Apr 8, 2024 •

edited by padmaia

Loading

ijjk commented Apr 8, 2024 •

edited

Loading

ijjk commented Apr 8, 2024 •

edited

Loading