Fix .env hmr for Node.js runtime in Turbopack #61504
Merged
+12
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Whenever
.env
related files or tsconfig/jsconfig changes there's a call toinvalidate()
, as far as I found the only call toinvalidate()
even, which wasn't implemented for Turbopack yet. ForNEXT_PUBLIC_
changes normal Turbopack HMR will kick in already but this test was checking env vars that do not affect the compiled output, so Turbopack would not trigger a HMR as no inputs changed. Similarly webpack doesn't either and it implements this call in a similar way.For edge runtime there's a different bug where changes are not propagated even when you refresh, so while this change does fix another bug for edge runtime it doesn't solve that underlying issue where the values don't update to begin with. I'll investigate that next.