Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update turbopack #61090

Merged
merged 1 commit into from
Jan 24, 2024
Merged

chore: update turbopack #61090

merged 1 commit into from
Jan 24, 2024
+44 −44

Conversation

ForsakenHarmony
Copy link
Contributor

@ForsakenHarmony ForsakenHarmony commented Jan 24, 2024 •
edited
Loading

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. type: next labels Jan 24, 2024
@ijjk
Copy link
Member

ijjk commented Jan 24, 2024 •
edited
Loading

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js hrmny/pack-2282-turbopack-assetprefix-fix Change
buildDuration 11.6s 11.7s ⚠️ +101ms
buildDurationCached 6.1s 5.1s N/A
nodeModulesSize 200 MB 200 MB ✓
nextStartRea..uration (ms) 434ms 432ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js hrmny/pack-2282-turbopack-assetprefix-fix Change
3f784ff6-HASH.js gzip 53.4 kB 53.4 kB ✓
423.HASH.js gzip 185 B 181 B N/A
68-HASH.js gzip 29.8 kB 29.8 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 238 B 240 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB ✓
Overall change 100 kB 100 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js hrmny/pack-2282-turbopack-assetprefix-fix Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js hrmny/pack-2282-turbopack-assetprefix-fix Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 502 B 502 B ✓
css-HASH.js gzip 320 B 322 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 256 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 368 B 369 B N/A
image-HASH.js gzip 4.18 kB 4.18 kB N/A
index-HASH.js gzip 257 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB N/A
routerDirect..HASH.js gzip 310 B 311 B N/A
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 306 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 608 B 608 B ✓
Client Build Manifests
vercel/next.js canary vercel/next.js hrmny/pack-2282-turbopack-assetprefix-fix Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js hrmny/pack-2282-turbopack-assetprefix-fix Change
index.html gzip 527 B 529 B N/A
link.html gzip 540 B 541 B N/A
withRouter.html gzip 521 B 524 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js hrmny/pack-2282-turbopack-assetprefix-fix Change
edge-ssr.js gzip 94 kB 94 kB N/A
page.js gzip 149 kB 149 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js hrmny/pack-2282-turbopack-assetprefix-fix Change
middleware-b..fest.js gzip 626 B 622 B N/A
middleware-r..fest.js gzip 151 B 149 B N/A
middleware.js gzip 37.6 kB 37.6 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 1.92 kB 1.92 kB ✓
Next Runtimes
vercel/next.js canary vercel/next.js hrmny/pack-2282-turbopack-assetprefix-fix Change
app-page-exp...dev.js gzip 170 kB 170 kB ✓
app-page-exp..prod.js gzip 95.7 kB 95.7 kB ✓
app-page-tur..prod.js gzip 96.3 kB 96.3 kB ✓
app-page-tur..prod.js gzip 90.9 kB 90.9 kB ✓
app-page.run...dev.js gzip 142 kB 142 kB ✓
app-page.run..prod.js gzip 90.2 kB 90.2 kB ✓
app-route-ex...dev.js gzip 22.2 kB 22.2 kB ✓
app-route-ex..prod.js gzip 14.9 kB 14.9 kB ✓
app-route-tu..prod.js gzip 14.9 kB 14.9 kB ✓
app-route-tu..prod.js gzip 14.5 kB 14.5 kB ✓
app-route.ru...dev.js gzip 21.6 kB 21.6 kB ✓
app-route.ru..prod.js gzip 14.5 kB 14.5 kB ✓
pages-api-tu..prod.js gzip 9.42 kB 9.42 kB ✓
pages-api.ru...dev.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru..prod.js gzip 9.42 kB 9.42 kB ✓
pages-turbo...prod.js gzip 22 kB 22 kB ✓
pages.runtim...dev.js gzip 22.6 kB 22.6 kB ✓
pages.runtim..prod.js gzip 22 kB 22 kB ✓
server.runti..prod.js gzip 49.7 kB 49.7 kB ✓
Overall change 932 kB 932 kB ✓
Commit: 0e8f724

@ForsakenHarmony ForsakenHarmony mentioned this pull request Jan 24, 2024
Merged
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/pack-2282-turbopack-assetprefix-fix branch from 97bec22 to 6d7af49 Compare January 24, 2024 16:42
@ForsakenHarmony
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ForsakenHarmony and the rest of your teammates on Graphite Graphite

ForsakenHarmony added a commit to vercel/turborepo that referenced this pull request Jan 24, 2024
@ForsakenHarmony
fix: don't escape base path in ecmascript runtime to allow for URLs (#…
d67c4bb 
…7093)

### Description

next's asset prefix can be a full URL, I think we can assume that the
basepath itself is valid.
we probably also want to ensure that the `chunkPath` never contains
invalid URL characters at build time so we don't need to escape anything
at all at runtime.

Need to make sure it passes all next.js tests
vercel/next.js#61090

Closes PACK-2282
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/pack-2282-turbopack-assetprefix-fix branch from 6d7af49 to 0e8f724 Compare January 24, 2024 20:12
@ForsakenHarmony ForsakenHarmony changed the title fix: don't escape base path in ecmascript runtime to allow for URLs chore: update turbopack Jan 24, 2024
@ForsakenHarmony ForsakenHarmony marked this pull request as ready for review January 24, 2024 20:14
@ForsakenHarmony ForsakenHarmony enabled auto-merge (squash) January 24, 2024 20:24
@ForsakenHarmony ForsakenHarmony merged commit ae12b30 into canary Jan 24, 2024
@ForsakenHarmony ForsakenHarmony deleted the hrmny/pack-2282-turbopack-assetprefix-fix branch January 24, 2024 20:44
@github-actions github-actions bot added the locked label Feb 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kwonoj kwonoj

@timneutkens timneutkens

@ijjk ijjk

@shuding shuding

@huozhi huozhi

@feedthejim feedthejim

@ztanner ztanner

@wyattjoh wyattjoh

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team. locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Turbopack] load wrong assetPrefix (it uses http://localhost:3000/http://cdn.com)
3 participants
@ForsakenHarmony @ijjk @kwonoj