Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: cover the tests with root tsconfig.json #59550

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Dec 12, 2023

We're using react automatic transform now, tsconfig.json jsx will be aligned as react-jsx. Some tests files are showing 'React' refers to a UMD global, but the current file is a module if there's no react import, cause they're not being covered by jsx config in tsconfig.json. Update the jsx config in root tsconfig.json to cover test ts/tsx files.

Adding a new test/tsconfig.json to resolve the modules and parsing jsx correctly

Closes NEXT-1859

@ijjk
Copy link
Member

ijjk commented Dec 13, 2023

Tests Passed

@huozhi huozhi marked this pull request as draft December 13, 2023 00:03
@ijjk
Copy link
Member

ijjk commented Dec 13, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js types/tsconfig-json-covert-tests Change
buildDuration 11.1s 11.1s N/A
buildDurationCached 6s 6.1s ⚠️ +142ms
nodeModulesSize 200 MB 200 MB
nextStartRea..uration (ms) 421ms 424ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js types/tsconfig-json-covert-tests Change
170-HASH.js gzip 26.8 kB 26.8 kB N/A
199.HASH.js gzip 181 B 185 B N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 240 B 241 B N/A
main-HASH.js gzip 31.7 kB 31.7 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 98.5 kB 98.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js types/tsconfig-json-covert-tests Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js types/tsconfig-json-covert-tests Change
_app-HASH.js gzip 195 B 194 B N/A
_error-HASH.js gzip 183 B 182 B N/A
amp-HASH.js gzip 501 B 501 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 255 B
head-HASH.js gzip 349 B 350 B N/A
hooks-HASH.js gzip 368 B 369 B N/A
image-HASH.js gzip 4.27 kB 4.27 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.6 kB N/A
routerDirect..HASH.js gzip 311 B 309 B N/A
script-HASH.js gzip 384 B 384 B
withRouter-HASH.js gzip 307 B 306 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.57 kB 1.57 kB
Client Build Manifests
vercel/next.js canary vercel/next.js types/tsconfig-json-covert-tests Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js types/tsconfig-json-covert-tests Change
index.html gzip 529 B 527 B N/A
link.html gzip 542 B 540 B N/A
withRouter.html gzip 524 B 521 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js types/tsconfig-json-covert-tests Change
edge-ssr.js gzip 93.7 kB 93.7 kB N/A
page.js gzip 146 kB 146 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js types/tsconfig-json-covert-tests Change
middleware-b..fest.js gzip 625 B 619 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 37.4 kB 37.4 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.07 kB 2.07 kB
Next Runtimes
vercel/next.js canary vercel/next.js types/tsconfig-json-covert-tests Change
app-page-exp...dev.js gzip 168 kB 168 kB
app-page-exp..prod.js gzip 94.1 kB 94.1 kB
app-page-tur..prod.js gzip 94.8 kB 94.8 kB
app-page-tur..prod.js gzip 89.4 kB 89.4 kB
app-page.run...dev.js gzip 138 kB 138 kB
app-page.run..prod.js gzip 88.7 kB 88.7 kB
app-route-ex...dev.js gzip 24 kB 24 kB
app-route-ex..prod.js gzip 16.6 kB 16.6 kB
app-route-tu..prod.js gzip 16.6 kB 16.6 kB
app-route-tu..prod.js gzip 16.2 kB 16.2 kB
app-route.ru...dev.js gzip 23.4 kB 23.4 kB
app-route.ru..prod.js gzip 16.2 kB 16.2 kB
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 22.5 kB 22.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 49.4 kB 49.4 kB
Overall change 930 kB 930 kB
Commit: 4ff8d56

@huozhi huozhi marked this pull request as ready for review December 13, 2023 10:49
@huozhi huozhi merged commit 61a7db6 into canary Dec 13, 2023
@huozhi huozhi deleted the types/tsconfig-json-covert-tests branch December 13, 2023 10:55
huozhi added a commit that referenced this pull request Dec 13, 2023
Inside `test/` folder we should use different path for alias paths
Follow up #59550
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants