Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add "Going to production" page for App Router #59304

Merged
merged 111 commits into from
Jan 5, 2024

Conversation

StephDietz
Copy link
Contributor

@StephDietz StephDietz commented Dec 5, 2023

  • Add Going to Prod docs for app
  • Add bundle-analyzer page
  • Merge app and pages docs

Verified

This commit was signed with the committer’s verified signature.
manovotny Michael Novotny
@ijjk
Copy link
Member

ijjk commented Dec 5, 2023

Allow CI Workflow Run

  • approve CI run for commit: 5fa5e6f

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Sorry, something went wrong.

StephDietz and others added 8 commits December 5, 2023 13:48
@StephDietz StephDietz marked this pull request as ready for review December 5, 2023 21:29
@StephDietz StephDietz requested review from a team as code owners December 5, 2023 21:29
@StephDietz StephDietz requested review from ismaelrumzan and jh3y and removed request for a team December 5, 2023 21:29
Copy link
Contributor

@delbaoliveira delbaoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this Steph 🙏🏼

Here are some other suggestions you might want to include in the Improving Performance section:

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ction-checklist.mdx

Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Dec 6, 2023

All broken links are now fixed, thank you!

StephDietz and others added 8 commits December 6, 2023 11:17

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ction-checklist.mdx

Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ction-checklist.mdx

Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ction-checklist.mdx

Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ction-checklist.mdx

Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ction-checklist.mdx

Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ction-checklist.mdx

Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ction-checklist.mdx

Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ction-checklist.mdx

Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
delbaoliveira and others added 3 commits December 22, 2023 11:38

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Rich Haines <hello@richardhaines.dev>
delbaoliveira and others added 8 commits December 22, 2023 16:06

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Lee Robinson <me@leerob.io>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ction-checklist.mdx

Co-authored-by: Lee Robinson <me@leerob.io>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@leerob leerob merged commit 694bd3e into canary Jan 5, 2024
@leerob leerob deleted the docs-app-router-production-page branch January 5, 2024 13:46
styfle pushed a commit that referenced this pull request Jan 5, 2024
agustints pushed a commit to agustints/next.js that referenced this pull request Jan 6, 2024
- Add **Going to Prod** docs for `app`
- Add bundle-analyzer page
- Merge `app` and `pages` docs

---------

Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
Co-authored-by: Michael Novotny <manovotny@gmail.com>
Co-authored-by: Delba de Oliveira <delbabrown@gmail.com>
Co-authored-by: Rich Haines <hello@richardhaines.dev>
Co-authored-by: Lee Robinson <me@leerob.io>
agustints pushed a commit to agustints/next.js that referenced this pull request Jan 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants