Revert "Revert "Add retry for fetching subsetted Google Fonts"" #58075
+41
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4d31506.
timneutkens
requested review from
a team,
ijjk,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
ijjk
added
Font (next/font)
Stats from current PRDefault BuildGeneral Overall increase
|
| vercel/next.js canary | vercel/next.js revert-57154-revert-56583-add-retry-for-font-fetching | Change | |
|---|---|---|---|
| buildDuration | 10.6s | 10.5s | N/A |
| buildDurationCached | 5.9s | 6.6s | |
| nodeModulesSize | 175 MB | 175 MB | |
| nextStartRea..uration (ms) | 420ms | 420ms | ✓ |
Client Bundles (main, webpack)
| vercel/next.js canary | vercel/next.js revert-57154-revert-56583-add-retry-for-font-fetching | Change | |
|---|---|---|---|
| 199-HASH.js gzip | 30.4 kB | 30.5 kB | N/A |
| 3f784ff6-HASH.js gzip | 53.2 kB | 53.2 kB | ✓ |
| 494.HASH.js gzip | 182 B | 182 B | ✓ |
| framework-HASH.js gzip | 45.5 kB | 45.5 kB | ✓ |
| main-app-HASH.js gzip | 252 B | 252 B | ✓ |
| main-HASH.js gzip | 33 kB | 33 kB | N/A |
| webpack-HASH.js gzip | 1.75 kB | 1.75 kB | N/A |
| Overall change | 99.2 kB | 99.2 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | vercel/next.js revert-57154-revert-56583-add-retry-for-font-fetching | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | vercel/next.js revert-57154-revert-56583-add-retry-for-font-fetching | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 205 B | 205 B | ✓ |
| _error-HASH.js gzip | 182 B | 181 B | N/A |
| amp-HASH.js gzip | 505 B | 507 B | N/A |
| css-HASH.js gzip | 322 B | 323 B | N/A |
| dynamic-HASH.js gzip | 2.59 kB | 2.59 kB | N/A |
| edge-ssr-HASH.js gzip | 258 B | 259 B | N/A |
| head-HASH.js gzip | 348 B | 347 B | N/A |
| hooks-HASH.js gzip | 369 B | 368 B | N/A |
| image-HASH.js gzip | 4.38 kB | 4.38 kB | N/A |
| index-HASH.js gzip | 256 B | 256 B | ✓ |
| link-HASH.js gzip | 2.71 kB | 2.7 kB | N/A |
| routerDirect..HASH.js gzip | 318 B | 318 B | ✓ |
| script-HASH.js gzip | 384 B | 383 B | N/A |
| withRouter-HASH.js gzip | 319 B | 320 B | N/A |
| 1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
| Overall change | 885 B | 885 B | ✓ |
Client Build Manifests
| vercel/next.js canary | vercel/next.js revert-57154-revert-56583-add-retry-for-font-fetching | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 483 B | 484 B | N/A |
| Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | vercel/next.js revert-57154-revert-56583-add-retry-for-font-fetching | Change | |
|---|---|---|---|
| index.html gzip | 529 B | 526 B | N/A |
| link.html gzip | 542 B | 540 B | N/A |
| withRouter.html gzip | 524 B | 522 B | N/A |
| Overall change | 0 B | 0 B | ✓ |
Edge SSR bundle Size
| vercel/next.js canary | vercel/next.js revert-57154-revert-56583-add-retry-for-font-fetching | Change | |
|---|---|---|---|
| edge-ssr.js gzip | 96.8 kB | 96.8 kB | N/A |
| page.js gzip | 151 kB | 151 kB | N/A |
| Overall change | 0 B | 0 B | ✓ |
Middleware size
| vercel/next.js canary | vercel/next.js revert-57154-revert-56583-add-retry-for-font-fetching | Change | |
|---|---|---|---|
| middleware-b..fest.js gzip | 625 B | 626 B | N/A |
| middleware-r..fest.js gzip | 148 B | 151 B | N/A |
| middleware.js gzip | 24.8 kB | 24.8 kB | ✓ |
| edge-runtime..pack.js gzip | 1.92 kB | 1.92 kB | ✓ |
| Overall change | 26.7 kB | 26.7 kB | ✓ |
Next Runtimes
| vercel/next.js canary | vercel/next.js revert-57154-revert-56583-add-retry-for-font-fetching | Change | |
|---|---|---|---|
| app-page-exp...dev.js gzip | 165 kB | 165 kB | ✓ |
| app-page-exp..prod.js gzip | 92.2 kB | 92.2 kB | ✓ |
| app-page-tur..prod.js gzip | 93 kB | 93 kB | ✓ |
| app-page-tur..prod.js gzip | 87.7 kB | 87.7 kB | ✓ |
| app-page.run...dev.js gzip | 135 kB | 135 kB | ✓ |
| app-page.run..prod.js gzip | 87 kB | 87 kB | ✓ |
| app-route-ex...dev.js gzip | 23.5 kB | 23.5 kB | ✓ |
| app-route-ex..prod.js gzip | 16.4 kB | 16.4 kB | ✓ |
| app-route-tu..prod.js gzip | 16.4 kB | 16.4 kB | ✓ |
| app-route-tu..prod.js gzip | 16 kB | 16 kB | ✓ |
| app-route.ru...dev.js gzip | 22.9 kB | 22.9 kB | ✓ |
| app-route.ru..prod.js gzip | 16 kB | 16 kB | ✓ |
| pages-api-tu..prod.js gzip | 9.37 kB | 9.37 kB | ✓ |
| pages-api.ru...dev.js gzip | 9.64 kB | 9.64 kB | ✓ |
| pages-api.ru..prod.js gzip | 9.37 kB | 9.37 kB | ✓ |
| pages-turbo...prod.js gzip | 21.5 kB | 21.5 kB | ✓ |
| pages.runtim...dev.js gzip | 22.2 kB | 22.2 kB | ✓ |
| pages.runtim..prod.js gzip | 21.5 kB | 21.5 kB | ✓ |
| server.runti..prod.js gzip | 48.5 kB | 48.5 kB | ✓ |
| Overall change | 913 kB | 913 kB | ✓ |
Tests Passed |
|
No top level dependency changes detected. Learn more about Socket for GitHub ↗︎ |
ztanner
approved these changes
Nov 6, 2023
kodiakhq
bot
deleted the
revert-57154-revert-56583-add-retry-for-font-fetching
branch
This was referenced Nov 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #57154
Brings back the changes but uses the compiled version of async-retry instead. Previously these changes causes an error as async-retry wasn't installed.