Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update experimental config check #57505

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 26, 2023

As discussed updates the warning with experimental config

@vercel-spaces
Copy link

vercel-spaces bot commented Oct 26, 2023

Notifying the following users due to files changed in this PR based on this repo's notify modifiers:

@timneutkens, @shuding, @styfle, @huozhi:

packages/next/src/server/config.ts

@ijjk
Copy link
Member Author

ijjk commented Oct 26, 2023

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/ppr-check Change
buildDuration 10.7s 10.6s N/A
buildDurationCached 6.2s 6.2s N/A
nodeModulesSize 175 MB 175 MB ⚠️ +1.98 kB
nextStartRea..uration (ms) 401ms 399ms N/A
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/ppr-check Change
199-HASH.js gzip 32.3 kB 32.4 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 35.3 kB 35.4 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 98.9 kB 98.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/ppr-check Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/ppr-check Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.99 kB 3.99 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/ppr-check Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/ppr-check Change
index.html gzip 528 B 530 B N/A
link.html gzip 541 B 542 B N/A
withRouter.html gzip 523 B 524 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary ijjk/next.js update/ppr-check Change
edge-ssr.js gzip 96 kB 96 kB N/A
page.js gzip 140 kB 140 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary ijjk/next.js update/ppr-check Change
middleware-b..fest.js gzip 623 B 622 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 25.8 kB 25.8 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Commit: a505ac7

@ijjk
Copy link
Member Author

ijjk commented Oct 26, 2023

Failing test suites

Commit: a505ac7

pnpm test-dev test/e2e/app-dir/metadata/metadata.test.ts

  • app dir - metadata > file based icons > should handle updates to the file icon name and order
  • app dir - metadata > static routes > should have icons as route
Expand output

● app dir - metadata › file based icons › should handle updates to the file icon name and order

TIMED OUT: /\/icons\/static\/icon2/

undefined

undefined

  626 |
  627 |   if (hardError) {
> 628 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  629 |   }
  630 |   return false
  631 | }

  at check (lib/next-test-utils.ts:628:11)
  at Object.<anonymous> (e2e/app-dir/metadata/metadata.test.ts:738:11)

● app dir - metadata › static routes › should have icons as route

expect(received).toBe(expected) // Object.is equality

Expected: 200
Received: 404

  850 |             : 'public, immutable, no-transform, max-age=31536000'
  851 |         )
> 852 |         expect(resIcon.status).toBe(200)
      |                                ^
  853 |         expect(resIcon.headers.get('content-type')).toBe('image/png')
  854 |         expect(resIcon.headers.get('cache-control')).toBe(
  855 |           isNextDev

  at Object.toBe (e2e/app-dir/metadata/metadata.test.ts:852:32)

Read more about building and testing Next.js in contributing.md.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@feedthejim feedthejim merged commit 340a9f7 into vercel:canary Oct 26, 2023
@ijjk ijjk deleted the update/ppr-check branch October 26, 2023 13:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants