-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify tailwindcss related dependency of create-next-app
#57262
Merged
kodiakhq
merged 2 commits into
vercel:canary
from
moka-ayumu:fix/create-next-app-dependency
Oct 30, 2023
Merged
Modify tailwindcss related dependency of create-next-app
#57262
kodiakhq
merged 2 commits into
vercel:canary
from
moka-ayumu:fix/create-next-app-dependency
Oct 30, 2023
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e05ebe3
to
0dffee9
Compare
kdy1
requested changes
Oct 26, 2023
kdy1
approved these changes
Oct 26, 2023
kdy1
requested changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking merge for now (for the conf)
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
0dffee9
to
f1383cc
Compare
kdy1
approved these changes
Oct 30, 2023
f1383cc
to
81ce8a9
Compare
ijjk
approved these changes
Oct 30, 2023
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
If the version of
autoprefixer
is 10.0.0 and the version oftailwindcss
is less than 3.3.0, the errorRangeError: Maximum call stack size exceeded
occurs when you create with tailwindcss & typescript and run it.Why?
The exact reason is unknown, but it appears to be a compatibility issue. Also, currently configuring tailwindcss with ts makes the tailwind config file in ts, which is supported since tailwindcss version 3.3.0. (In js, it works even if you set the version of
autoprefixer
to 10.0.1 and lower the version of tailwindcss.)How?
Simply default the minimum version of
autoprefixer
to 10.0.1 and the minimum version oftailwindcss
to 3.3.0.