Bump packages version to match canary versions #57071

huozhi · 2023-10-19T18:27:37Z

We released 13.5.6 as stable patch, need to bump the canary version higher than stable to match the semantics

ijjk · 2023-10-19T18:31:33Z

Failing test suites

Commit: efb7a7b

pnpm test test/integration/create-next-app/index.test.ts

create next app > empty directory
create next app > should fall back to default template
create next app > should allow an example named default
create next app > should create a project in the current directory
create next app > should ask the user for a name for the project if none supplied

Expand output

● create next app › empty directory

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  81 |   for (const file of files) {
  82 |     try {
> 83 |       expect(existsSync(resolve(projectRoot, file))).toBe(true)
     |                                                      ^
  84 |     } catch (err) {
  85 |       require('console').error(
  86 |         `missing expected file ${file}`,

  at toBe (integration/create-next-app/lib/utils.ts:83:54)
  at projectFilesShouldExist (integration/create-next-app/lib/utils.ts:133:3)
  at shouldBeTemplateProject (integration/create-next-app/lib/utils.ts:172:3)
  at integration/create-next-app/index.test.ts:82:34
  at useTempDir (lib/use-temp-dir.ts:24:5)
  at Object.<anonymous> (integration/create-next-app/index.test.ts:66:7)

● create next app › should fall back to default template

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  81 |   for (const file of files) {
  82 |     try {
> 83 |       expect(existsSync(resolve(projectRoot, file))).toBe(true)
     |                                                      ^
  84 |     } catch (err) {
  85 |       require('console').error(
  86 |         `missing expected file ${file}`,

  at toBe (integration/create-next-app/lib/utils.ts:83:54)
  at projectFilesShouldExist (integration/create-next-app/lib/utils.ts:133:3)
  at shouldBeTemplateProject (integration/create-next-app/lib/utils.ts:172:3)
  at integration/create-next-app/index.test.ts:322:34
  at useTempDir (lib/use-temp-dir.ts:24:5)
  at Object.<anonymous> (integration/create-next-app/index.test.ts:302:7)

● create next app › should allow an example named default

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  81 |   for (const file of files) {
  82 |     try {
> 83 |       expect(existsSync(resolve(projectRoot, file))).toBe(true)
     |                                                      ^
  84 |     } catch (err) {
  85 |       require('console').error(
  86 |         `missing expected file ${file}`,

  at toBe (integration/create-next-app/lib/utils.ts:83:54)
  at projectFilesShouldExist (integration/create-next-app/lib/utils.ts:133:3)
  at shouldBeTemplateProject (integration/create-next-app/lib/utils.ts:172:3)
  at integration/create-next-app/index.test.ts:346:32
  at useTempDir (lib/use-temp-dir.ts:24:5)
  at Object.<anonymous> (integration/create-next-app/index.test.ts:328:5)

● create next app › should create a project in the current directory

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  81 |   for (const file of files) {
  82 |     try {
> 83 |       expect(existsSync(resolve(projectRoot, file))).toBe(true)
     |                                                      ^
  84 |     } catch (err) {
  85 |       require('console').error(
  86 |         `missing expected file ${file}`,

  at toBe (integration/create-next-app/lib/utils.ts:83:54)
  at projectFilesShouldExist (integration/create-next-app/lib/utils.ts:133:3)
  at shouldBeTemplateProject (integration/create-next-app/lib/utils.ts:172:3)
  at integration/create-next-app/index.test.ts:452:32
  at useTempDir (lib/use-temp-dir.ts:24:5)
  at Object.<anonymous> (integration/create-next-app/index.test.ts:415:5)

● create next app › should ask the user for a name for the project if none supplied

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  81 |   for (const file of files) {
  82 |     try {
> 83 |       expect(existsSync(resolve(projectRoot, file))).toBe(true)
     |                                                      ^
  84 |     } catch (err) {
  85 |       require('console').error(
  86 |         `missing expected file ${file}`,

  at toBe (integration/create-next-app/lib/utils.ts:83:54)
  at projectFilesShouldExist (integration/create-next-app/lib/utils.ts:133:3)
  at shouldBeTemplateProject (integration/create-next-app/lib/utils.ts:172:3)
  at integration/create-next-app/index.test.ts:475:32
  at useTempDir (lib/use-temp-dir.ts:24:5)
  at Object.<anonymous> (integration/create-next-app/index.test.ts:457:5)

Read more about building and testing Next.js in contributing.md.

pnpm test test/integration/create-next-app/package-manager.test.ts

should use npm as the package manager on supplying --use-npm
should use Yarn as the package manager on supplying --use-yarn
should use pnpm as the package manager on supplying --use-pnpm
should use Bun as the package manager on supplying --use-bun
should infer npm as the package manager
should infer yarn as the package manager
should infer pnpm as the package manager
should infer Bun as the package manager

Expand output

● should use npm as the package manager on supplying --use-npm

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  81 |   for (const file of files) {
  82 |     try {
> 83 |       expect(existsSync(resolve(projectRoot, file))).toBe(true)
     |                                                      ^
  84 |     } catch (err) {
  85 |       require('console').error(
  86 |         `missing expected file ${file}`,

  at toBe (integration/create-next-app/lib/utils.ts:83:54)
  at projectFilesShouldExist (integration/create-next-app/lib/utils.ts:133:3)
  at shouldBeTemplateProject (integration/create-next-app/lib/utils.ts:172:3)
  at integration/create-next-app/package-manager.test.ts:56:30
  at useTempDir (lib/use-temp-dir.ts:24:5)
  at Object.<anonymous> (integration/create-next-app/package-manager.test.ts:36:3)

● should use Yarn as the package manager on supplying --use-yarn

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  81 |   for (const file of files) {
  82 |     try {
> 83 |       expect(existsSync(resolve(projectRoot, file))).toBe(true)
     |                                                      ^
  84 |     } catch (err) {
  85 |       require('console').error(
  86 |         `missing expected file ${file}`,

  at toBe (integration/create-next-app/lib/utils.ts:83:54)
  at integration/create-next-app/package-manager.test.ts:112:28
  at useTempDir (lib/use-temp-dir.ts:24:5)
  at Object.<anonymous> (integration/create-next-app/package-manager.test.ts:92:3)

● should use pnpm as the package manager on supplying --use-pnpm

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  81 |   for (const file of files) {
  82 |     try {
> 83 |       expect(existsSync(resolve(projectRoot, file))).toBe(true)
     |                                                      ^
  84 |     } catch (err) {
  85 |       require('console').error(
  86 |         `missing expected file ${file}`,

  at toBe (integration/create-next-app/lib/utils.ts:83:54)
  at integration/create-next-app/package-manager.test.ts:190:28
  at useTempDir (lib/use-temp-dir.ts:24:5)
  at Object.<anonymous> (integration/create-next-app/package-manager.test.ts:170:3)

● should use Bun as the package manager on supplying --use-bun

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  81 |   for (const file of files) {
  82 |     try {
> 83 |       expect(existsSync(resolve(projectRoot, file))).toBe(true)
     |                                                      ^
  84 |     } catch (err) {
  85 |       require('console').error(
  86 |         `missing expected file ${file}`,

  at toBe (integration/create-next-app/lib/utils.ts:83:54)
  at integration/create-next-app/package-manager.test.ts:268:28
  at useTempDir (lib/use-temp-dir.ts:24:5)
  at Object.<anonymous> (integration/create-next-app/package-manager.test.ts:248:3)

● should infer npm as the package manager

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  81 |   for (const file of files) {
  82 |     try {
> 83 |       expect(existsSync(resolve(projectRoot, file))).toBe(true)
     |                                                      ^
  84 |     } catch (err) {
  85 |       require('console').error(
  86 |         `missing expected file ${file}`,

  at toBe (integration/create-next-app/lib/utils.ts:83:54)
  at integration/create-next-app/package-manager.test.ts:350:28
  at useTempDir (lib/use-temp-dir.ts:24:5)
  at Object.<anonymous> (integration/create-next-app/package-manager.test.ts:322:3)

● should infer yarn as the package manager

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  81 |   for (const file of files) {
  82 |     try {
> 83 |       expect(existsSync(resolve(projectRoot, file))).toBe(true)
     |                                                      ^
  84 |     } catch (err) {
  85 |       require('console').error(
  86 |         `missing expected file ${file}`,

  at toBe (integration/create-next-app/lib/utils.ts:83:54)
  at integration/create-next-app/package-manager.test.ts:422:28
  at useTempDir (lib/use-temp-dir.ts:24:5)
  at Object.<anonymous> (integration/create-next-app/package-manager.test.ts:394:3)

● should infer pnpm as the package manager

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  81 |   for (const file of files) {
  82 |     try {
> 83 |       expect(existsSync(resolve(projectRoot, file))).toBe(true)
     |                                                      ^
  84 |     } catch (err) {
  85 |       require('console').error(
  86 |         `missing expected file ${file}`,

  at toBe (integration/create-next-app/lib/utils.ts:83:54)
  at integration/create-next-app/package-manager.test.ts:505:28
  at useTempDir (lib/use-temp-dir.ts:24:5)
  at Object.<anonymous> (integration/create-next-app/package-manager.test.ts:477:3)

● should infer Bun as the package manager

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  81 |   for (const file of files) {
  82 |     try {
> 83 |       expect(existsSync(resolve(projectRoot, file))).toBe(true)
     |                                                      ^
  84 |     } catch (err) {
  85 |       require('console').error(
  86 |         `missing expected file ${file}`,

  at toBe (integration/create-next-app/lib/utils.ts:83:54)
  at integration/create-next-app/package-manager.test.ts:584:28
  at useTempDir (lib/use-temp-dir.ts:24:5)
  at Object.<anonymous> (integration/create-next-app/package-manager.test.ts:556:3)

Read more about building and testing Next.js in contributing.md.

ijjk · 2023-10-19T18:33:05Z

Stats from current PR

Default Build

General

	vercel/next.js canary	vercel/next.js bump-version	Change
buildDuration	10.4s	10.4s	N/A
buildDurationCached	6s	6.1s	⚠️ +108ms
nodeModulesSize	174 MB	174 MB	✓
nextStartRea..uration (ms)	513ms	512ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js bump-version	Change
199-HASH.js gzip	27.5 kB	27.5 kB	N/A
3f784ff6-HASH.js gzip	53.3 kB	53.3 kB	✓
99.HASH.js gzip	182 B	182 B	✓
framework-HASH.js gzip	45.3 kB	45.3 kB	✓
main-app-HASH.js gzip	254 B	251 B	N/A
main-HASH.js gzip	32.9 kB	32.9 kB	N/A
webpack-HASH.js gzip	1.75 kB	1.75 kB	N/A
Overall change	98.8 kB	98.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js bump-version	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js bump-version	Change
_app-HASH.js gzip	206 B	205 B	N/A
_error-HASH.js gzip	182 B	180 B	N/A
amp-HASH.js gzip	506 B	505 B	N/A
css-HASH.js gzip	322 B	323 B	N/A
dynamic-HASH.js gzip	2.57 kB	2.57 kB	N/A
edge-ssr-HASH.js gzip	260 B	259 B	N/A
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	369 B	369 B	✓
image-HASH.js gzip	4.36 kB	4.36 kB	N/A
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.64 kB	2.63 kB	N/A
routerDirect..HASH.js gzip	312 B	311 B	N/A
script-HASH.js gzip	385 B	384 B	N/A
withRouter-HASH.js gzip	307 B	308 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	1.08 kB	1.08 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js bump-version	Change
_buildManifest.js gzip	484 B	482 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js bump-version	Change
index.html gzip	529 B	530 B	N/A
link.html gzip	544 B	542 B	N/A
withRouter.html gzip	524 B	524 B	✓
Overall change	524 B	524 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js bump-version	Change
edge-ssr.js gzip	93.7 kB	93.7 kB	N/A
page.js gzip	155 kB	155 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js bump-version	Change
middleware-b..fest.js gzip	623 B	622 B	N/A
middleware-r..fest.js gzip	150 B	151 B	N/A
middleware.js gzip	22.5 kB	22.5 kB	N/A
edge-runtime..pack.js gzip	1.92 kB	1.92 kB	✓
Overall change	1.92 kB	1.92 kB	✓

Commit: efb7a7b

socket-security · 2023-10-19T18:36:05Z

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: next@13.5.6-canary.8

styfle · 2023-10-19T19:13:59Z

@huozhi @feedthejim This looks like it broke another test

❌ test/integration/create-next-app/package-manager.test.ts output:

npm ERR! notarget No matching version found for eslint-config-next@13.5.7-canary.8.

https://github.com/vercel/next.js/actions/runs/6578876460/job/17873547337?pr=57071#step:28:166

ijjk added create-next-app created-by: Next.js team type: next labels Oct 19, 2023

Bump packages version to match canary versions

efb7a7b

huozhi force-pushed the bump-version branch from 1563ef2 to efb7a7b Compare October 19, 2023 18:39

huozhi marked this pull request as ready for review October 19, 2023 18:47

huozhi requested review from timneutkens, ijjk, shuding, a team, feedthejim, ztanner and wyattjoh as code owners October 19, 2023 18:47

styfle approved these changes Oct 19, 2023

View reviewed changes

feedthejim merged commit a6aae86 into canary Oct 19, 2023

feedthejim deleted the bump-version branch October 19, 2023 19:09

github-actions bot added the locked label Nov 3, 2023

github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump packages version to match canary versions #57071

Bump packages version to match canary versions #57071

huozhi commented Oct 19, 2023 •

edited

Loading

ijjk commented Oct 19, 2023 •

edited

Loading

ijjk commented Oct 19, 2023 •

edited

Loading

socket-security bot commented Oct 19, 2023

styfle commented Oct 19, 2023

Bump packages version to match canary versions #57071

Bump packages version to match canary versions #57071

Conversation

huozhi commented Oct 19, 2023 • edited Loading

ijjk commented Oct 19, 2023 • edited Loading

Failing test suites

ijjk commented Oct 19, 2023 • edited Loading

Stats from current PR

socket-security bot commented Oct 19, 2023

styfle commented Oct 19, 2023

huozhi commented Oct 19, 2023 •

edited

Loading

ijjk commented Oct 19, 2023 •

edited

Loading

ijjk commented Oct 19, 2023 •

edited

Loading