-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make next as dependency of @next/third-parties
package
#53996
Merged
Merged
+33
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failing test suitesCommit: 8df4adb
Expand output● @next/third-parties basic usage › renders YoutubeEmbed
● @next/third-parties basic usage › renders GoogleMapsEmbed
Read more about building and testing Next.js in contributing.md. |
@next/third-parties
package
styfle
reviewed
Aug 14, 2023
styfle
previously approved these changes
Aug 14, 2023
shuding
previously approved these changes
Aug 14, 2023
ijjk
reviewed
Aug 14, 2023
ijjk
reviewed
Aug 14, 2023
ijjk
reviewed
Aug 14, 2023
ijjk
reviewed
Aug 14, 2023
styfle
previously approved these changes
Aug 14, 2023
ijjk
approved these changes
Aug 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensure
next
is the dependency of third-parties package so turbo will build next first then@next/third-parties
to avoid type failing