chore(docs): client-side data fetching loading state #53164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setLoading must be "true" at first and then set to "false". The documentation, as is, always has the value of setLoading set to "false".
styfle
previously approved these changes
Jul 25, 2023
styfle
reviewed
Jul 25, 2023
docs/03-pages/01-building-your-application/03-data-fetching/05-client-side.mdx
Outdated
Show resolved
Hide resolved
styfle
approved these changes
Jul 25, 2023
styfle
changed the title
kwonoj
pushed a commit
that referenced
this pull request
Jul 26, 2023
setLoading must be "true" at first and then set to "false". The documentation, as is, always has the value of setLoading set to "false". The purpose of this code is to show "...loading" on the screen while the data is being fetched. In order for this to happen, setLoading must be initially set to "true" and then (after the data is successfully loaded) set to "false", since the line `if (isLoading) return <p>Loading...</p>` is asking if the content is still loading, and if it is, it'll return a message indicating it. Because of this ### What? setLoading should be set to "true" at first. ### Why? Because the code then asks if the content is being loaded. The code (as is) always has setLoading set as "false" and it doesn't show the loading message when it's supposed to. ### How? I changed the line to `const [isLoading, setLoading] = useState(true)`. Co-authored-by: Steven <229881+styfle@users.noreply.github.com>
rfearing
pushed a commit
to rfearing/next.js
that referenced
this pull request
Jul 26, 2023
setLoading must be "true" at first and then set to "false". The documentation, as is, always has the value of setLoading set to "false". The purpose of this code is to show "...loading" on the screen while the data is being fetched. In order for this to happen, setLoading must be initially set to "true" and then (after the data is successfully loaded) set to "false", since the line `if (isLoading) return <p>Loading...</p>` is asking if the content is still loading, and if it is, it'll return a message indicating it. Because of this ### What? setLoading should be set to "true" at first. ### Why? Because the code then asks if the content is being loaded. The code (as is) always has setLoading set as "false" and it doesn't show the loading message when it's supposed to. ### How? I changed the line to `const [isLoading, setLoading] = useState(true)`. Co-authored-by: Steven <229881+styfle@users.noreply.github.com>
Strift
pushed a commit
to Strift/next.js
that referenced
this pull request
Jul 27, 2023
setLoading must be "true" at first and then set to "false". The documentation, as is, always has the value of setLoading set to "false". The purpose of this code is to show "...loading" on the screen while the data is being fetched. In order for this to happen, setLoading must be initially set to "true" and then (after the data is successfully loaded) set to "false", since the line `if (isLoading) return <p>Loading...</p>` is asking if the content is still loading, and if it is, it'll return a message indicating it. Because of this ### What? setLoading should be set to "true" at first. ### Why? Because the code then asks if the content is being loaded. The code (as is) always has setLoading set as "false" and it doesn't show the loading message when it's supposed to. ### How? I changed the line to `const [isLoading, setLoading] = useState(true)`. Co-authored-by: Steven <229881+styfle@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setLoading must be "true" at first and then set to "false". The documentation, as is, always has the value of setLoading set to "false".
The purpose of this code is to show "...loading" on the screen while the data is being fetched. In order for this to happen, setLoading must be initially set to "true" and then (after the data is successfully loaded) set to "false", since the line
if (isLoading) return <p>Loading...</p>is asking if the content is still loading, and if it is, it'll return a message indicating it.Because of this
What?
setLoading should be set to "true" at first.
Why?
Because the code then asks if the content is being loaded. The code (as is) always has setLoading set as "false" and it doesn't show the loading message when it's supposed to.
How?
I changed the line to
const [isLoading, setLoading] = useState(true).