Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cross-platform rm -rf script #49529

Merged
merged 5 commits into from May 10, 2023
Merged

Conversation

ForsakenHarmony
ForsakenHarmony previously approved these changes May 9, 2023
@ijjk
Copy link
Member

ijjk commented May 9, 2023

Failing test suites

Commit: 8b92ae4

pnpm testheadless test/e2e/middleware-fetches-with-body/index.test.ts

  • Middleware fetches with body > with custom bodyParser sizeLimit (5mb) > should return 413 for body equal to 10mb
Expand output

● Middleware fetches with body › with custom bodyParser sizeLimit (5mb) › should return 413 for body equal to 10mb

expect(received).toBe(expected) // Object.is equality

Expected: 413
Received: 500

  177 |       )
  178 |
> 179 |       expect(res.status).toBe(413)
      |                          ^
  180 |
  181 |       if (!(global as any).isNextDeploy) {
  182 |         expect(res.statusText).toBe('Body exceeded 5mb limit')

  at Object.<anonymous> (e2e/middleware-fetches-with-body/index.test.ts:179:26)

Read more about building and testing Next.js in contributing.md.

@kachkaev
Copy link
Contributor

kachkaev commented May 9, 2023

Duplicate of #49522?

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

🚮 Removed packages: @types/node@12.12.24, @types/rimraf@3.0.0

@kodiakhq kodiakhq bot merged commit 11a7117 into canary May 10, 2023
102 checks passed
@kodiakhq kodiakhq bot deleted the add-rm-mjs-script-windows branch May 10, 2023 01:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'rm' command alternative to support build on a Windows & Linux OS machine
4 participants