[NEXT-1101] Regression using nested routes with params

[tommybarvaag]

Verify canary release

• I verified that the issue exists in the latest Next.js canary release

Provide environment information

Operating System:
      Platform: darwin
      Arch: arm64
      Version: Darwin Kernel Version 22.4.0: Mon Mar  6 20:59:58 PST 2023; root:xnu-8796.101.5~3/RELEASE_ARM64_T6020
    Binaries:
      Node: 18.15.0
      npm: 9.5.0
      Yarn: 1.22.19
      pnpm: 8.4.0
    Relevant packages:
      next: 13.3.5-canary.8
      eslint-config-next: 13.3.4
      react: 18.2.0
      react-dom: 18.2.0

Which area(s) of Next.js are affected? (leave empty if unsure)

App directory (appDir: true)

Link to the code that reproduces this issue

https://github.com/tommybarvaag/nested-routes-with-params

To Reproduce

Everything works as expected locally with next dev but crashes when hosted @vercel.

Click the link Go to second params page on the page https://nested-routes-with-params.vercel.app.

This crashes the page. Resulting in a blank render.

If we peek into the console you can see the following error

On further inspection in Vercel logs we can read the following

TypeError: Cannot read properties of undefined (reading 'first')
    at (node_modules/.pnpm/next@13.3.4_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/esm/server/app-render/app-render.js:174:0)
    at (node_modules/.pnpm/next@13.3.4_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/esm/server/app-render/app-render.js:450:0)
    at (node_modules/.pnpm/next@13.3.4_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/esm/server/app-render/app-render.js:441:0)
    at (node_modules/.pnpm/next@13.3.4_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/esm/server/app-render/app-render.js:477:75)
    at (node_modules/.pnpm/next@13.3.4_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/esm/server/app-render/app-render.js:441:0)
    at (node_modules/.pnpm/next@13.3.4_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/esm/server/app-render/app-render.js:759:57)

And

TypeError: Cannot read properties of null (reading 'default')
    at (node_modules/.pnpm/next@13.3.4_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/esm/build/webpack/loaders/next-edge-ssr-loader/render.js:65:0)
    at (node_modules/.pnpm/next@13.3.4_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/esm/server/web-server.js:349:0)
    at (node_modules/.pnpm/next@13.3.4_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/esm/server/base-server.js:1413:0)
    at (node_modules/.pnpm/next@13.3.4_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/esm/server/base-server.js:1311:0)
    at (node_modules/.pnpm/next@13.3.4_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/esm/server/base-server.js:563:0)
    at (node_modules/.pnpm/next@13.3.4_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/esm/server/web-server.js:258:0)
    at (node_modules/.pnpm/next@13.3.4_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/esm/server/router.js:294:0)
    at (node_modules/.pnpm/next@13.3.4_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/esm/server/base-server.js:537:0)

And

 Error: An error occurred in the Server Components render. The specific message is omitted in production builds to avoid leaking sensitive details. A digest property is included on this error instance which may provide additional details about the nature of the error. {
  digest: '951169804'
}

Describe the Bug

Next crashes with nesting routes with params.

The reproduction repo contains the following route structure

├── app
│   ├── layout.tsx
│   └── page.tsx
│   └── first
│   │   ├── [first]
│   │   │   ├── page.tsx
│   │   │   └── second
│   │   │   │   ├── [second]
│   │   │   │   │   ├── page.tsx

When navigating to the [second] page Next will throw an error because the first parameter is undefined.

Expected Behavior

Shouldn't crash.

Which browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

Vercel

_NEXT-1101

[hansottowirtz]

We're also seeing this error since upgrading from 13.3.1-canary.4 to higher.

Seems like params is not defined here:

next.js/packages/next/src/server/app-render/app-render.tsx

Line 285 in 25a9547

const pathParams = (renderOpts as any).params as ParsedUrlQuery

[tommybarvaag]

Tested with latest canary 13.4.1-canary.1 and this still fails @vercel but works locally.

Operating System:
      Platform: darwin
      Arch: arm64
      Version: Darwin Kernel Version 22.4.0: Mon Mar  6 20:59:58 PST 2023; root:xnu-8796.101.5~3/RELEASE_ARM64_T6020
    Binaries:
      Node: 18.15.0
      npm: 9.5.0
      Yarn: 1.22.19
      pnpm: 8.4.0
    Relevant packages:
      next: 13.4.1-canary.1
      eslint-config-next: 13.4.0
      react: 18.2.0
      react-dom: 18.2.0

[huozhi]

Does latest version 13.4.1 fix your issue?

[hansottowirtz]

@huozhi No, still the same error.

[tommybarvaag]

@huozhi Upgraded the reproduction site to 13.4.1 and it still gives the same error.

https://nested-routes-with-params.vercel.app

[huozhi]

We can repro now, I've marked it as a bug and we're investigating now 🙏

[tommybarvaag]

@huozhi I updated the repro to 13.4.2-canary.2 and the page with nested params is now working.

[timneutkens]

Should be fixed by #49315 indeed 👍 Thanks for checking!

[github-actions]

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.