Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Add ElasticSearch example #28043

Merged
merged 15 commits into from
Aug 24, 2021
Merged

[examples] Add ElasticSearch example #28043

merged 15 commits into from
Aug 24, 2021
+383 −0

Conversation

aravindputrevu
Copy link
Contributor

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

Sorry, something went wrong.

@ijjk ijjk added the examples Issue was opened via the examples template. label Aug 12, 2021
aravindputrevu and others added 2 commits August 18, 2021 23:52
@aravindputrevu
Moved all the CSS into CSS Modules

Verified

This commit was signed with the committer’s verified signature.
aduh95 Antoine du Hamel
GPG key ID: 21D900FFDB233756
Verified
Learn about vigilant mode
a1bc3e0
@aravindputrevu
Merge branch 'canary' into canary
1fab791
@aravindputrevu
Copy link
Contributor Author

Please let me know if there are any changes needed further.

leerob
leerob previously approved these changes Aug 18, 2021
View reviewed changes
aravindputrevu and others added 2 commits August 19, 2021 15:51
@aravindputrevu
Merge branch 'canary' into canary

Verified

This commit was signed with the committer’s verified signature.
richardlau Richard Lau
GPG key ID: C43CEC45C17AB93C
Verified
Learn about vigilant mode
5ae2217
@kodiakhq
Merge branch 'canary' into canary

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600
Verified
Learn about vigilant mode
811d9f8
@aravindputrevu
Copy link
Contributor Author

@leerob Could you please help me with what's going wrong with the example check? I've definitely staged all the commits!

@leerob
Copy link
Member

leerob commented Aug 20, 2021

There's a few failing checks that will need to be addressed, and then it's good to go! E.g. linting

leerob
leerob previously approved these changes Aug 23, 2021
View reviewed changes
@leerob leerob changed the title Elasticsearch nextjs example [examples] Add ElasticSearch example Aug 23, 2021
@kodiakhq kodiakhq bot merged commit a143bc4 into vercel:canary Aug 24, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob

@ijjk ijjk

@lfades lfades

@shuding shuding

@timneutkens timneutkens

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aravindputrevu @leerob @ijjk