Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix html validation for Image component sizer #27767

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Fix html validation for Image component sizer #27767

merged 2 commits into from
Aug 4, 2021
+0 −1

Conversation

styfle
Copy link
Member

@styfle styfle commented Aug 4, 2021

According to MDN:

  • aria-hidden="true" will remove the entire element from the accessibility API.
  • role="presentation" will remove the semantic meaning of an element while still exposing it to assistive technology.

We don't need both so we'll keep aria-hidden="true" since the element is used for sizing, not content that should be read.

Fixes #27163

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Aug 4, 2021
@styfle styfle mentioned this pull request Aug 4, 2021
Closed
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Aug 4, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vercel/next.js fix-html-validation-aria-sizer Change
buildDuration 19s 18.7s -297ms
buildDurationCached 4.2s 4.2s -56ms
nodeModulesSize 50.1 MB 50.1 MB -88 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix-html-validation-aria-sizer Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.319 3.248 -0.07
/ avg req/sec 753.18 769.77 +16.59
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.081 1.998 -0.08
/error-in-render avg req/sec 1201.07 1251.07 +50
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix-html-validation-aria-sizer Change
745.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 23.1 kB 23.1 kB ✓
webpack-HASH.js gzip 1.5 kB 1.5 kB ✓
Overall change 67 kB 67 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-html-validation-aria-sizer Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages Overall decrease ✓
vercel/next.js canary vercel/next.js fix-html-validation-aria-sizer Change
_app-HASH.js gzip 980 B 980 B ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 329 B 329 B ✓
dynamic-HASH.js gzip 2.52 kB 2.52 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 904 B 904 B ✓
image-HASH.js gzip 4.13 kB 4.12 kB -11 B
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 319 B 319 B ✓
script-HASH.js gzip 387 B 387 B ✓
withRouter-HASH.js gzip 320 B 320 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 12.8 kB 12.8 kB -11 B
Client Build Manifests Overall decrease ✓
vercel/next.js canary vercel/next.js fix-html-validation-aria-sizer Change
_buildManifest.js gzip 492 B 490 B -2 B
Overall change 492 B 490 B -2 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-html-validation-aria-sizer Change
index.html gzip 531 B 531 B ✓
link.html gzip 542 B 542 B ✓
withRouter.html gzip 523 B 523 B ✓
Overall change 1.6 kB 1.6 kB ✓

Diffs

Diff for _buildManifest.js 
@@ -17,7 +17,7 @@ self.__BUILD_MANIFEST = {
     "static\u002Fchunks\u002Fpages\u002Fhooks-1cb3a46057c08067a973.js"
   ],
   "/image": [
-    "static\u002Fchunks\u002Fpages\u002Fimage-1ad88e6dd5c62e24187c.js"
+    "static\u002Fchunks\u002Fpages\u002Fimage-ffe48e73c00abc6054aa.js"
   ],
   "/link": ["static\u002Fchunks\u002Fpages\u002Flink-7a3c1e637e71f2a0e489.js"],
   "/routerDirect": [
Diff for image-HASH.js 
@@ -628,7 +628,6 @@
                       },
                       alt: "",
                       "aria-hidden": true,
-                      role: "presentation",
                       src: "data:image/svg+xml;base64,".concat(
                         (0, _toBase64).toBase64(sizerSvg)
                       )
Webpack 4 Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vercel/next.js fix-html-validation-aria-sizer Change
buildDuration 15.4s 15.1s -289ms
buildDurationCached 5.8s 5.6s -131ms
nodeModulesSize 50.1 MB 50.1 MB -88 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix-html-validation-aria-sizer Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.391 3.282 -0.11
/ avg req/sec 737.26 761.75 +24.49
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.118 2.088 -0.03
/error-in-render avg req/sec 1180.58 1197.41 +16.83
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix-html-validation-aria-sizer Change
17.HASH.js gzip 185 B 185 B ✓
677f882d2ed8..HASH.js gzip 14 kB 14 kB ✓
framework.HASH.js gzip 41.9 kB 41.9 kB ✓
main-HASH.js gzip 10.5 kB 10.5 kB ✓
webpack-HASH.js gzip 1.19 kB 1.19 kB ✓
Overall change 67.8 kB 67.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix-html-validation-aria-sizer Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary vercel/next.js fix-html-validation-aria-sizer Change
_app-HASH.js gzip 965 B 965 B ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 552 B 552 B ✓
css-HASH.js gzip 333 B 333 B ✓
dynamic-HASH.js gzip 2.71 kB 2.71 kB ✓
head-HASH.js gzip 2.97 kB 2.97 kB ✓
hooks-HASH.js gzip 911 B 911 B ✓
index-HASH.js gzip 231 B 231 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 298 B 298 B ✓
script-HASH.js gzip 2.94 kB 2.94 kB ✓
withRouter-HASH.js gzip 294 B 294 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 17.7 kB 17.7 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js fix-html-validation-aria-sizer Change
_buildManifest.js gzip 499 B 499 B ✓
Overall change 499 B 499 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix-html-validation-aria-sizer Change
index.html gzip 577 B 577 B ✓
link.html gzip 589 B 589 B ✓
withRouter.html gzip 570 B 570 B ✓
Overall change 1.74 kB 1.74 kB ✓
Commit: 92421d4

@kodiakhq kodiakhq bot merged commit 2061d6c into canary Aug 4, 2021
@kodiakhq kodiakhq bot deleted the fix-html-validation-aria-sizer branch August 4, 2021 18:43
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
@styfle
Fix html validation for Image component sizer (vercel#27767)
9179b5f 
According to [MDN](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-hidden_attribute#deciding_between_aria-hiddentrue_rolepresentation_and_rolenone):


- `aria-hidden="true"` will remove the entire element from the accessibility API. 
- `role="presentation"` will remove the semantic meaning of an element while still exposing it to assistive technology. 

We don't need both so we'll keep `aria-hidden="true"` since the element is used for sizing, not content that should be read.

Fixes vercel#27163
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk

@huozhi huozhi

@padmaia padmaia

@shuding shuding

@timneutkens timneutkens

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

next/image generates invalid html tag (empty alt attribute)
2 participants
@styfle @ijjk