move next/script
to pages/_app
in script loader integration tests
#27626
+23
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the integration tests for
next/script
currently import theScript
component inpages/_document.js
. according to docs however,next/script
"should not be used inpages/_document.js
" but inpages/_app.js
.this pr moves
next/script
frompages/_document
topages/_app
- at least locally thescript-loader
tests still pass. @janicklas-ralph does this make sense?this would unblock #27257
Bug
fixes #number
contributing.md
Feature
fixes #number
contributing.md
Documentation / Examples