Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Next.js postcss version to cssnano-simple #26952

Merged
merged 2 commits into from
Jul 8, 2021

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Jul 6, 2021

This ensures the correct version of postcss is always used even when npm does not resolve peerdeps correctly.

Depends on Timer/cssnano-simple#16

Fixes #24882

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

Sorry, something went wrong.

This ensures the correct version of postcss is always used even when npm does not resolve peerdeps correctly.

Depends on Timer/cssnano-simple#16
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Jul 7, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/24882 Change
buildDuration 13s 13.1s ⚠️ +65ms
buildDurationCached 3.3s 3.2s -51ms
nodeModulesSize 49.3 MB 49.3 MB ⚠️ +162 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/24882 Change
/ failed reqs 0 0
/ total time (seconds) 2.317 2.336 ⚠️ +0.02
/ avg req/sec 1079.1 1070.08 ⚠️ -9.02
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.309 1.286 -0.02
/error-in-render avg req/sec 1909.82 1943.65 +33.83
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/24882 Change
359.HASH.js gzip 3.09 kB 3.09 kB
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 20.6 kB 20.6 kB
webpack-HASH.js gzip 1.49 kB 1.49 kB
Overall change 67.2 kB 67.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/24882 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/24882 Change
_app-HASH.js gzip 803 B 803 B
_error-HASH.js gzip 3.18 kB 3.18 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 329 B 329 B
hooks-HASH.js gzip 903 B 903 B
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.42 kB 8.42 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/24882 Change
_buildManifest.js gzip 390 B 390 B
Overall change 390 B 390 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/24882 Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/24882 Change
buildDuration 11.3s 11.2s -170ms
buildDurationCached 4.5s 4.4s -42ms
nodeModulesSize 49.3 MB 49.3 MB ⚠️ +162 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/24882 Change
/ failed reqs 0 0
/ total time (seconds) 2.319 2.312 -0.01
/ avg req/sec 1078.14 1081.33 +3.19
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.293 1.263 -0.03
/error-in-render avg req/sec 1932.97 1979.67 +46.7
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/24882 Change
14.HASH.js gzip 3.11 kB 3.11 kB
677f882d2ed8..HASH.js gzip 13.9 kB 13.9 kB
framework.HASH.js gzip 41.8 kB 41.8 kB
main-HASH.js gzip 7.81 kB 7.81 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 67.8 kB 67.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/24882 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/24882 Change
_app-HASH.js gzip 791 B 791 B
_error-HASH.js gzip 3.83 kB 3.83 kB
amp-HASH.js gzip 531 B 531 B
css-HASH.js gzip 333 B 333 B
hooks-HASH.js gzip 910 B 910 B
index-HASH.js gzip 230 B 230 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 297 B 297 B
withRouter-HASH.js gzip 293 B 293 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 8.98 kB 8.98 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/24882 Change
_buildManifest.js gzip 418 B 418 B
Overall change 418 B 418 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/24882 Change
index.html gzip 575 B 575 B
link.html gzip 586 B 586 B
withRouter.html gzip 568 B 568 B
Overall change 1.73 kB 1.73 kB
Commit: f64745f

@timneutkens timneutkens merged commit 20200ad into vercel:canary Jul 8, 2021
@timneutkens timneutkens deleted the fix/24882 branch July 8, 2021 11:10
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing postcss dependency on build
2 participants