Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: vercel/next.js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v15.0.4-canary.27
Choose a base ref
...
head repository: vercel/next.js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v15.0.4-canary.28
Choose a head ref
  • 18 commits
  • 108 files changed
  • 10 contributors

Commits on Nov 25, 2024

  1. port turbopack-swc-utils to ResolvedVc (#73086) 

    <!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the PR.
- Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to understand the PR)
- When linking to a Slack thread, you might want to share details of the conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->
    @arlyon
    arlyon authored Nov 25, 2024
    Copy the full SHA
    06fed46 View commit details

  2. port turbopack-mdx to use ResolvedVc (#73080) 

    <!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the PR.
- Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to understand the PR)
- When linking to a Slack thread, you might want to share details of the conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->
    @arlyon
    arlyon authored Nov 25, 2024
    Copy the full SHA
    70be965 View commit details

  3. feat: Update lightningcss to v1.0.0-alpha.61 (#73161) 

    ### What?

Update `lightningcss` to the latest. 

 - https://github.com/parcel-bundler/lightningcss/releases/tag/v1.28.2

### Why?

It's released.
    @kdy1
    kdy1 authored Nov 25, 2024
    Copy the full SHA
    2bf4779 View commit details

  4. port turbopack-resolve to ResolvedVc (#73083) 

    <!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the PR.
- Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to understand the PR)
- When linking to a Slack thread, you might want to share details of the conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->
    @arlyon
    arlyon authored Nov 25, 2024
    Copy the full SHA
    2853a5d View commit details

  5. move turbopack-image to ResolvedVc (#73079) 

    <!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the PR.
- Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to understand the PR)
- When linking to a Slack thread, you might want to share details of the conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->
    @arlyon
    arlyon authored Nov 25, 2024
    Copy the full SHA
    1cade4e View commit details

  6. Turbopack: more tracing spans (#73010) 

    - adds per-module tracing for `find server actions` (it's implemented in
the same way for next/dynamic and client references). Now, `find server
actions` isn't just a single blob anymore.
- add a tracing span for `all_server_paths`
    @mischnic
    mischnic authored Nov 25, 2024
    Copy the full SHA
    1899edd View commit details

  7. Reenable otel test for Turbopack (#73093) 

    Turbopack has supported instrumentation.js for a long time now
    @mischnic
    mischnic authored Nov 25, 2024
    Copy the full SHA
    56b28ce View commit details

  8. Omit unnecessary cache wrapper import (#73160) 

    When a `"use cache"` module has no exported or annotated cache function, we can omit the import statement for the cache wrapper function.
    @unstubbable
    unstubbable authored Nov 25, 2024
    Copy the full SHA
    adfdd09 View commit details

  9. Handle server function directives in class methods (#73060) 

    With this PR, we are allowing _static_ class methods to be annotated with `"use cache"` or `"use server"`.

Class _instance_ methods on the other hand are not allowed as server functions.
    @unstubbable
    unstubbable authored Nov 25, 2024
    Copy the full SHA
    6602327 View commit details

  10. 15.1 docs: forbidden, unauthorized, and authInterrupts (#73039) 

    **Do not merge until #72785 lands
in canary.**

Closes:
-
https://linear.app/vercel/issue/DOC-3820/[unstable]-forbidden-and-forbiddenjs
-
https://linear.app/vercel/issue/DOC-3849/[unstable]-unauthorized-and-unauthorizedjs
-
https://linear.app/vercel/issue/DOC-3860/[experimental]-authinterrupts-config-option
    @delbaoliveira
    delbaoliveira authored Nov 25, 2024
    Copy the full SHA
    712d7c9 View commit details

  11. Enable another Turbopack build test (#73166) 

    We forgot to update the manifest when merging the NFT PRs
    @mischnic
    mischnic authored Nov 25, 2024
    Copy the full SHA
    690dcac View commit details

  12. CNA: replace .eslintrc.json with eslint.config.mjs (#73162) 

    ### Why?

As we upgraded create-next-app ESLint to v9, use flat config (with
compatible function) for the templates.

`eslint.config.mjs`:

```mjs
import { dirname } from "path";
import { fileURLToPath } from "url";
import { FlatCompat } from "@eslint/eslintrc";

const __filename = fileURLToPath(import.meta.url);
const __dirname = dirname(__filename);

const compat = new FlatCompat({
  baseDirectory: __dirname,
});

const eslintConfig = [...compat.extends("next/core-web-vitals")];

export default eslintConfig;
```

As `import.meta.dirname` was introduced in Node.js version v20.11.0, we
can simplify to when on minimum version:

```mjs
import { FlatCompat } from "@eslint/eslintrc";

const compat = new FlatCompat({
  baseDirectory: import.meta.dirname,
});

const eslintConfig = [...compat.extends("next/core-web-vitals")];

export default eslintConfig;
```

But best is that other dependency plugins support flat config so we can
upgrade to pure Flat Config as well.

Closes NDX-374
    @devjiwonchoi
    devjiwonchoi authored Nov 25, 2024
    Copy the full SHA
    82cac69 View commit details

  13. Turbopack: don't compute all paths for builds (#73036) 

    Depends on #73010

A very small speedup, mostly noticeable in cpu time, not really in wall
time
```
before:
    504.86s user 73.31s system 792% cpu 1:12.93 total
    522.09s user 76.70s system 778% cpu 1:16.94 total
    503.73s user 68.78s system 818% cpu 1:09.92 total
after: 
    471.20s user 61.73s system 757% cpu 1:10.33 total
    481.69s user 69.05s system 805% cpu 1:08.33 total
```
    @mischnic
    mischnic authored Nov 25, 2024
    Copy the full SHA
    2d4d837 View commit details

  14. Increase max cache tags to 128 (#73124)

    @ijjk
    ijjk authored Nov 25, 2024
    Copy the full SHA
    6d69b0c View commit details

  15. perf(turbopack): Use ResolvedVc for turbopack-css (#73172) 

    ### What?

Use `ResolvedVc<T>` instead of `Vc<T>` for struct fields in
`turbopack-css`

### Why?

### How?
    @kdy1
    kdy1 authored Nov 25, 2024
    Copy the full SHA
    3ddd390 View commit details

  16. Revert change to ReactRefreshRequire test (#73186) 

    See #73105 (comment)
    @gaojude
    gaojude authored Nov 25, 2024
    Copy the full SHA
    e4646d6 View commit details

  17. chore(CI): Remove sysroot override for macos arm64 (#73188) 

    This is extracted from #72513. This override appears to break the build for rocksdb. It doesn't seem like there's any good reason for us to do this.

It looks like we used to do a cross-build for macos arm64 (#28138), which would explain the need to override the sysroot, but we don't do that anymore. We don't do this override for x86-64 builds (even though that one _is_ a cross-build? The napi cli probably does the right thing for us...).

Manually triggered `build-and-deploy` CI job: https://github.com/vercel/next.js/actions/runs/12018322261
    @bgw
    bgw authored Nov 25, 2024
    Copy the full SHA
    e0eed7d View commit details

  18. v15.0.4-canary.28

    @vercel-release-bot
    vercel-release-bot committed Nov 25, 2024
    2
    Copy the full SHA
    43566f1 View commit details
Loading