Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: vercel/next.js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v15.0.1
Choose a base ref
...
head repository: vercel/next.js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2e28c965279de90ce4bfca673196c27dd6117027
Choose a head ref

Commits on Oct 23, 2024

  1. docs: fix broken link in Architecture/Turbopack documentation (#71412)

    This PR fixes a broken link (404 Not Found) in the
    [Architecture/Turbopack](https://nextjs.org/docs/architecture/turbopack)
    documentation.
    
    It appears the actual URL differs from the expected one, so I have
    corrected it to the expected URL.
    
    expected URL :
    https://nextjs.org/docs/canary/architecture/nextjs-compiler#supported-features
    actual URL :
    https://nextjs.org/docs/canary/architecture/docs/canary/architecture/nextjs-compiler#supported-features
    
    
    ![image](https://github.com/user-attachments/assets/ea63f62d-f00a-4a02-a330-20be1e8a67c7)
    
    Co-authored-by: JJ Kasper <jj@jjsweb.site>
    ytori and ijjk authored Oct 23, 2024
    Copy the full SHA
    b258244 View commit details
  2. Read page name from work store in server module map proxy (#71669)

    This avoids a race condition when running `next build` where the
    manifest singleton might be overwritten with the next page's manifest
    while the previous page is still being rendered.
    
    With this PR, we are not storing a page-specific singleton but the whole
    manifest, and only when accessing an entry is the page read from the
    work store, and thus scoped to the current page. An exception is when a
    server module map is needed during module evaluation when no work store
    is provided, e.g. to create a server action using a higher-order
    function. In this case it should be safe to return any entry from the
    manifest that matches the action ID. They all refer to the same module
    ID, which must also exist in the current page bundle. (This is currently
    not guaranteed in Turbopack, and needs to be fixed.)
    unstubbable authored Oct 23, 2024
    Copy the full SHA
    03ff785 View commit details
  3. Copy the full SHA
    f91cdec View commit details
  4. Copy the full SHA
    5a54933 View commit details
  5. fix: docs for dynamic routing in next 15 (#71531)

    ### What?
    
    Fixes the `params` prop in
    https://nextjs.org/docs/canary/app/building-your-application/routing/dynamic-routes
    
    Also fixes a typo: `synchronoulsy` -> `synchronously`
    ### Why?
    
    There is a breaking change in `next@15.0.0-rc.1`:
    https://nextjs.org/blog/next-15-rc2#async-request-apis-breaking-change
    
    Although the api docs have been updated, these have not been.
    
    ### How?
    
    updates the docs. (relevant) build and lint passes locally. ran the
    prettier fix.
    
    ---------
    
    Co-authored-by: JJ Kasper <jj@jjsweb.site>
    SebassNoob and ijjk authored Oct 23, 2024
    1
    Copy the full SHA
    96d6a96 View commit details
  6. [Docs] Remove the 'new' keyword from the GET function sample code. (#…

    …71671)
    
    The json() method returns a Response object, so remove the new keyword.
    
    <!-- Thanks for opening a PR! Your contribution is much appreciated.
    To make sure your PR is handled as smoothly as possible we request that
    you follow the checklist sections below.
    Choose the right checklist for the change(s) that you're making:
    
    ## For Contributors
    
    ### Improving Documentation
    
    - Run `pnpm prettier-fix` to fix formatting issues before opening the
    PR.
    - Read the Docs Contribution Guide to ensure your contribution follows
    the docs guidelines:
    https://nextjs.org/docs/community/contribution-guide
    
    ### Adding or Updating Examples
    
    - The "examples guidelines" are followed from our contributing doc
    https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
    - Make sure the linting passes by running `pnpm build && pnpm lint`. See
    https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md
    
    ### Fixing a bug
    
    - Related issues linked using `fixes #number`
    - Tests added. See:
    https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
    - Errors have a helpful link attached, see
    https://github.com/vercel/next.js/blob/canary/contributing.md
    
    ### Adding a feature
    
    - Implements an existing feature request or RFC. Make sure the feature
    request has been accepted for implementation before opening a PR. (A
    discussion must be opened, see
    https://github.com/vercel/next.js/discussions/new?category=ideas)
    - Related issues/discussions are linked using `fixes #number`
    - e2e tests added
    (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
    - Documentation added
    - Telemetry added. In case of a feature if it's used or not.
    - Errors have a helpful link attached, see
    https://github.com/vercel/next.js/blob/canary/contributing.md
    
    
    ## For Maintainers
    
    - Minimal description (aim for explaining to someone not on the team to
    understand the PR)
    - When linking to a Slack thread, you might want to share details of the
    conclusion
    - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
    - Add review comments if necessary to explain to the reviewer the logic
    behind a change
    
    ### What?
    
    ### Why?
    
    ### How?
    
    Closes NEXT-
    Fixes #
    
    -->
    
    Co-authored-by: JJ Kasper <jj@jjsweb.site>
    tatsuteb and ijjk authored Oct 23, 2024
    Copy the full SHA
    5abd117 View commit details
  7. chore: fix wrong path of comments (#71682)

    ## Description
    At #44405, many files moved.
    Then sync comment paths.
    
    Co-authored-by: JJ Kasper <jj@jjsweb.site>
    Marukome0743 and ijjk authored Oct 23, 2024
    Copy the full SHA
    4292752 View commit details
  8. [dynamicIO] complete refactor to prerender (#71687)

    In the initial change to adopt prerender for SSR for dynamicIO I missed
    an instance of renderToReadableStream. This completes the work
    gnoff authored Oct 23, 2024
    Copy the full SHA
    d61d631 View commit details
  9. Copy the full SHA
    c1cfee3 View commit details
  10. fix: metadata image route normalize path posix for windows (#71673)

    ### Why?
    
    When handling the opengraph-image size exceeding the limit, we mapped
    with string literal between Rust and JavaScript. The Rust string literal
    contains backslashes `\` on Windows, incompatible with JavaScript string
    syntax.
    
    Following up on #71615.
    
    Fixes #71582
    devjiwonchoi authored Oct 23, 2024
    Copy the full SHA
    9fac077 View commit details
  11. next-codemod(upgrade): optional catch when missing dev script (#71598)

    ### Why?
    
    During the next-codemod upgrade, when the `dev` script is missing, it
    throws while reading `.includes` the undefined value.
    
    Fixes #71597
    
    ---------
    
    Co-authored-by: Jiwon Choi <devjiwonchoi@gmail.com>
    imprakharshukla and devjiwonchoi authored Oct 23, 2024
    Copy the full SHA
    e9b18d6 View commit details
  12. Copy the full SHA
    51d6e76 View commit details
  13. fix: exclude basePath in findSourceMapURL (#71719)

    This PR fixes #71706.
    
    When having an error client side and there is a `basePath` defined, the
    basePath is being used to locate the sourcemap of the given file which
    results in an error.
    
    With these changes the `basePath` gets removed from the `filename`
    passed to `findSourceMapURL`
    
    If you have questions, feel free to ask!
    migueldamota authored Oct 23, 2024
    Copy the full SHA
    ca559a5 View commit details
  14. Copy the full SHA
    3643c8b View commit details
  15. react-sync: Ignore update notices from npm (#71717)

    `npm view` prints a notice when a new update is available
    to `stderr` tricking us into thinking there was an error.
    ```
    npm notice
    npm notice New minor version of npm available! 10.7.0 -> 10.9.0
    npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.9.0
    npm notice To update run: npm install -g npm@10.9.0
    npm notice
    ```
    
    Running with `--silent` avoids these unrelated warnings (see npm/npm#2040 (comment)).
    
    ## Test plan
    
    #71718
    eps1lon authored Oct 23, 2024
    Copy the full SHA
    b08f755 View commit details
  16. Copy the full SHA
    aed6c4c View commit details
  17. next-codemod: add empty pnpm-workspace.yaml to test fixtures to byp…

    …ass PNPM workspace checks (#71726)
    
    ### Why?
    
    Since dep installation within next-codemod runs `pnpm install` on the
    Next.js repo, it installs in the workspace root scope during testing. We
    could add a layer for testing like adding a flag `--no-workspace`, but
    it will reduce confidence between the actual running and testing.
    Therefore added an empty `pnpm-workspace.yaml` file to each fixture.
    
    ### How?
    
    By doing this, both installation and testing will have same environment
    of running, `pnpm install` only. To prevent created `pnpm-lockfile` to
    be shipped, gitignored it.
    
    This way, we keep things simple and make sure tests match real-world use
    better. The empty `pnpm-workspace.yaml` files make `pnpm` treat each
    fixture separately, which is closer to how it'll work for users.
    devjiwonchoi authored Oct 23, 2024
    Copy the full SHA
    741f830 View commit details
  18. warn on sync access if dynamicIO is not enabled (#71696)

    Since `console.error` is intercepted, this can be frustrating when a 3p
    library that hasn't updated to use the async APIs triggers a warning.
    
    This keeps the error behavior when `dynamicIO` is enabled and warns in
    other cases.
    ztanner authored Oct 23, 2024
    Copy the full SHA
    bbad635 View commit details
  19. v15.0.2-canary.0

    vercel-release-bot committed Oct 23, 2024
    2
    Copy the full SHA
    40790d8 View commit details
  20. Docs: Update default marker for fetch cache option (#71728)

    This page was showing the outdated default.
    
    <!-- Thanks for opening a PR! Your contribution is much appreciated.
    To make sure your PR is handled as smoothly as possible we request that
    you follow the checklist sections below.
    Choose the right checklist for the change(s) that you're making:
    
    ## For Contributors
    
    ### Improving Documentation
    
    - Run `pnpm prettier-fix` to fix formatting issues before opening the
    PR.
    - Read the Docs Contribution Guide to ensure your contribution follows
    the docs guidelines:
    https://nextjs.org/docs/community/contribution-guide
    
    ### Adding or Updating Examples
    
    - The "examples guidelines" are followed from our contributing doc
    https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
    - Make sure the linting passes by running `pnpm build && pnpm lint`. See
    https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md
    
    ### Fixing a bug
    
    - Related issues linked using `fixes #number`
    - Tests added. See:
    https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
    - Errors have a helpful link attached, see
    https://github.com/vercel/next.js/blob/canary/contributing.md
    
    ### Adding a feature
    
    - Implements an existing feature request or RFC. Make sure the feature
    request has been accepted for implementation before opening a PR. (A
    discussion must be opened, see
    https://github.com/vercel/next.js/discussions/new?category=ideas)
    - Related issues/discussions are linked using `fixes #number`
    - e2e tests added
    (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
    - Documentation added
    - Telemetry added. In case of a feature if it's used or not.
    - Errors have a helpful link attached, see
    https://github.com/vercel/next.js/blob/canary/contributing.md
    
    
    ## For Maintainers
    
    - Minimal description (aim for explaining to someone not on the team to
    understand the PR)
    - When linking to a Slack thread, you might want to share details of the
    conclusion
    - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
    - Add review comments if necessary to explain to the reviewer the logic
    behind a change
    
    ### What?
    
    ### Why?
    
    ### How?
    
    Closes NEXT-
    Fixes #
    
    -->
    timneutkens authored Oct 23, 2024
    Copy the full SHA
    4835be1 View commit details
  21. [docs] Fix page.tsx parameter types (#71680)

    Closes #71679
    
    Co-authored-by: Zack Tanner <1939140+ztanner@users.noreply.github.com>
    cantemizyurek and ztanner authored Oct 23, 2024
    Copy the full SHA
    e1632cc View commit details
  22. [docs] Fix table.js containing TS code (#71677)

    Closes #71675.
    
    Co-authored-by: Zack Tanner <1939140+ztanner@users.noreply.github.com>
    cantemizyurek and ztanner authored Oct 23, 2024
    Copy the full SHA
    465d1bb View commit details
  23. Copy the full SHA
    babc6a0 View commit details
  24. next-upgrade: do not add --turbopack flag when --turbo exists in …

    …`next dev` (#71730)
    
    ### Why?
    
    1. When `next dev --turbo` existed, it added `--turbopack` since it was
    looking for existing `--turbopack` only.
    2. When there's no `"dev"` script found in package.json, inform the user
    we weren't able to enable Turbopack for them.
    
    
    - https://github.com/vercel/next.js/releases/tag/v15.0.1-canary.3
    
    ## Test Plan
    
    ### Suggest Turbopack
    
    ```
    pnpm test:upgrade-fixture bin/__testfixtures__/suggest-turbopack
    ```
    
    ```diff
       "scripts": {
    -    "dev": "next dev"
    +    "dev": "next dev --turbopack"
       },
    ```
    
    ### Change `--turbo` to `--turbopack`
    
    ```
    pnpm test:upgrade-fixture bin/__testfixtures__/change-turbo-to-turbopack
    ```
    
    CLI output includes:
    ```
    ✔ Replaced "--turbo" with "--turbopack" in your dev script.
    ```
    
    ```diff
       "scripts": {
    -    "dev": "next dev --turbo"
    +    "dev": "next dev --turbopack"
       },
    ```
    devjiwonchoi authored Oct 23, 2024
    Copy the full SHA
    6fba7b2 View commit details
  25. Copy the full SHA
    064970e View commit details
  26. [dynamicIO] update data access error and documentation (#71738)

    It will be quite common to attempt to access data during prerendering
    and encounter the error that indicates you did not provide a Suspense
    boundary to define fallback UI. This change updates the error message
    and includes a link to a new docs page which explains how to handle this
    error.
    
    ---------
    
    Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
    gnoff and delbaoliveira authored Oct 23, 2024
    Copy the full SHA
    3a39a20 View commit details
  27. docs(ppr): update note about ppr (#71697)

    ## Why?
    
    Let's clarify this is only available in canary. We need to remove it
    from the stable docs later.
    samcx authored Oct 23, 2024
    Copy the full SHA
    b3d7335 View commit details
  28. Copy the full SHA
    544d98b View commit details
  29. docs lint (#71748)

    `easy` and `just` are failing lint checks.
    ztanner authored Oct 23, 2024
    Copy the full SHA
    1cb70c4 View commit details
  30. Copy the full SHA
    c464672 View commit details
  31. Copy the full SHA
    627a5ff View commit details
  32. Fix race condition when setting client reference manifests (#71741)

    Similar to how #71669 fixed a race condition when setting the manifests
    singleton regarding the server action manifests, this PR fixes the same
    race condition for the client reference manifests.
    unstubbable authored Oct 23, 2024
    Copy the full SHA
    3265c95 View commit details
  33. v15.0.2-canary.1

    vercel-release-bot committed Oct 23, 2024
    1
    Copy the full SHA
    f06906a View commit details
  34. Fix docs for configuring Turbopack (#71755)

    ### What?
    Fixes code examples for configuring Turbopack. Turbopack Dev is stable,
    but we're keeping the configuration options under `experimental` until
    Turbopack Build is stable as well. Most of these options will not
    change, but we didn't want a combination of experimental and stable
    options.
    
    
    Closes PACK-3324
    padmaia authored Oct 23, 2024
    Copy the full SHA
    82196b8 View commit details
  35. Copy the full SHA
    dca6516 View commit details
  36. Copy the full SHA
    54768ac View commit details
  37. [dynamicIO] unify cache filling and lazy-module warming (#71749)

    We ended up with up to three prerender passes as we added support for
    new use cases like lazy module initializaiton. This update refactors the
    PPR pathway to have at most two renders.
    
    I will follow up with a refactor of the non-ppr pathway next.
    gnoff authored Oct 23, 2024
    Copy the full SHA
    ab32cca View commit details
  38. Don't filter out <anonymous> source location frames through RSC (#71752)

    This lets us show Server Components (and Host Components) in the Parent
    Stack passed to errors.
    
    <img width="1039" alt="Screenshot 2024-10-23 at 12 51 10 PM"
    src="https://github.com/user-attachments/assets/5912e750-b544-403d-8d5a-bce91c01b3a8">
    sebmarkbage authored Oct 23, 2024
    Copy the full SHA
    53f2193 View commit details
  39. Copy the full SHA
    8d61b88 View commit details
  40. docs(turbo): add experimental icon to turbo config section (#71761)

    ## Why?
    
    The `turbo` config is still experimental in v15.
    
    - Fixes #71750
    - Related PR: #71755
    samcx authored Oct 23, 2024
    Copy the full SHA
    e54338a View commit details
  41. v15.0.2-canary.2

    vercel-release-bot committed Oct 23, 2024
    2
    Copy the full SHA
    4bc32c3 View commit details
  42. Upgrade React from 28668d39-20241023 to 1631855f-20241023 (#71769)

    **breaking change for canary users: Bumps peer dependency of React from
    `19.0.0-rc-28668d39-20241023` to `19.0.0-rc-1631855f-20241023`**
    
    [diff
    facebook/react@28668d39...1631855f](facebook/react@28668d3...1631855)
    
    <details>
    <summary>React upstream changes</summary>
    
    - facebook/react#31340
    
    </details>
    vercel-release-bot authored Oct 23, 2024
    Copy the full SHA
    4ae3fc3 View commit details

Commits on Oct 24, 2024

  1. Copy the full SHA
    dbc9452 View commit details
  2. feat: add experiment for sharpjs cpu flags (#71733)

    This PR adds two experimental flags to configure sharpjs settings that
    may improve cpu for image optimization.
    styfle authored Oct 24, 2024
    Copy the full SHA
    0dce6bb View commit details
  3. fix: handle server component replay error in error overlay (#71772)

    ### What
    
    When there's a replay console error showed up, display it in error
    overlay.
    
    #### Server Component Page
    <img width="480" alt="image"
    src="https://github.com/user-attachments/assets/7af65809-1e0e-4aa0-bffb-bc95a376fb02">
    
    #### Server Component Page with Client Components
    <img width="480" alt="image"
    src="https://github.com/user-attachments/assets/1f8bd507-3e0f-43f3-9240-07c4aec16ab4">
    
    ---------
    
    Co-authored-by: Sebastian Markbage <sebastian@calyptus.eu>
    huozhi and sebmarkbage authored Oct 24, 2024
    Copy the full SHA
    ab1d9ee View commit details
  4. Don't error asking for prebuilt bundles (#71778)

    Turbopack doesn't recognize webpack:// and so errors otherwise.
    
    We don't need source maps for internals.
    
    <img width="774" alt="Screenshot 2024-10-23 at 10 13 02 PM"
    src="https://github.com/user-attachments/assets/72ec2ecc-7fbb-4a2a-9978-8d8c365ab966">
    sebmarkbage authored Oct 24, 2024
    Copy the full SHA
    f5e5107 View commit details
  5. Replace turbopack://[project]/... sourcemap uris with file://...

    …in development (#71489)
    
    This makes working with devtools more straightforward, reduces our own
    overhead when tracing stack frames in the error overlay, etc.
    
    Generated code from Turbopack or Next.js still use
    `turbopack://[turbopack]` or `turbopack://[next]` respectively.
    
    Test Plan: 
    - [x] Update tests
    - [x] CI
    - [x]
    https://github.com/vercel/next.js/blob/475bdb1f743bf0b3552b40f85b615d87f4ae4904/test/development/app-dir/source-mapping/README.md
    
    ---------
    
    Co-authored-by: Benjamin Woodruff <benjamin.woodruff@vercel.com>
    Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
    3 people authored Oct 24, 2024
    Copy the full SHA
    2a10d55 View commit details
  6. misc: update source map paths for bundled Next.js runtime (#71779)

    <!-- Thanks for opening a PR! Your contribution is much appreciated.
    To make sure your PR is handled as smoothly as possible we request that
    you follow the checklist sections below.
    Choose the right checklist for the change(s) that you're making:
    
    ## For Contributors
    
    ### Improving Documentation
    
    - Run `pnpm prettier-fix` to fix formatting issues before opening the
    PR.
    - Read the Docs Contribution Guide to ensure your contribution follows
    the docs guidelines:
    https://nextjs.org/docs/community/contribution-guide
    
    ### Adding or Updating Examples
    
    - The "examples guidelines" are followed from our contributing doc
    https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
    - Make sure the linting passes by running `pnpm build && pnpm lint`. See
    https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md
    
    ### Fixing a bug
    
    - Related issues linked using `fixes #number`
    - Tests added. See:
    https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
    - Errors have a helpful link attached, see
    https://github.com/vercel/next.js/blob/canary/contributing.md
    
    ### Adding a feature
    
    - Implements an existing feature request or RFC. Make sure the feature
    request has been accepted for implementation before opening a PR. (A
    discussion must be opened, see
    https://github.com/vercel/next.js/discussions/new?category=ideas)
    - Related issues/discussions are linked using `fixes #number`
    - e2e tests added
    (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
    - Documentation added
    - Telemetry added. In case of a feature if it's used or not.
    - Errors have a helpful link attached, see
    https://github.com/vercel/next.js/blob/canary/contributing.md
    
    
    ## For Maintainers
    
    - Minimal description (aim for explaining to someone not on the team to
    understand the PR)
    - When linking to a Slack thread, you might want to share details of the
    conclusion
    - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
    - Add review comments if necessary to explain to the reviewer the logic
    behind a change
    
    ### What?
    
    ### Why?
    
    ### How?
    
    Closes NEXT-
    Fixes #
    
    -->
    
    This changes the generated source map to not do the
    "webpack://next/dist/<file>" and instead use the relative path. this
    allows us to use the vanilla ignoreList "node_modules" config to also
    also ignore those files
    
    ![CleanShot 2024-10-23 at 22 41
    37@2x](https://github.com/user-attachments/assets/387bdf1e-c507-459c-8740-8e9587ebb0ca)
    
    ![CleanShot 2024-10-23 at 22 42
    03@2x](https://github.com/user-attachments/assets/5fc45209-292b-4f53-8e86-541def464286)
    feedthejim authored Oct 24, 2024
    Copy the full SHA
    a19b952 View commit details
  7. v15.0.2-canary.3

    vercel-release-bot committed Oct 24, 2024
    1
    Copy the full SHA
    9d1cf5e View commit details
  8. [dynamicIO] refine error message and docs (#71781)

    refines the error message for non-prerenderable holes while prerendering
    as well as the docs
    gnoff authored Oct 24, 2024
    1
    Copy the full SHA
    17f4291 View commit details
Loading