-
Notifications
You must be signed in to change notification settings - Fork 28k
Comparing changes
Open a pull request
base repository: vercel/next.js
base: v15.0.1
head repository: vercel/next.js
compare: 2e28c965279de90ce4bfca673196c27dd6117027
Commits on Oct 23, 2024
-
docs: fix broken link in Architecture/Turbopack documentation (#71412)
This PR fixes a broken link (404 Not Found) in the [Architecture/Turbopack](https://nextjs.org/docs/architecture/turbopack) documentation. It appears the actual URL differs from the expected one, so I have corrected it to the expected URL. expected URL : https://nextjs.org/docs/canary/architecture/nextjs-compiler#supported-features actual URL : https://nextjs.org/docs/canary/architecture/docs/canary/architecture/nextjs-compiler#supported-features  Co-authored-by: JJ Kasper <jj@jjsweb.site>
Configuration menu - View commit details
-
Copy full SHA for b258244 - Browse repository at this point
Copy the full SHA b258244View commit details -
Read page name from work store in server module map proxy (#71669)
This avoids a race condition when running `next build` where the manifest singleton might be overwritten with the next page's manifest while the previous page is still being rendered. With this PR, we are not storing a page-specific singleton but the whole manifest, and only when accessing an entry is the page read from the work store, and thus scoped to the current page. An exception is when a server module map is needed during module evaluation when no work store is provided, e.g. to create a server action using a higher-order function. In this case it should be safe to return any entry from the manifest that matches the action ID. They all refer to the same module ID, which must also exist in the current page bundle. (This is currently not guaranteed in Turbopack, and needs to be fixed.)
Configuration menu - View commit details
-
Copy full SHA for 03ff785 - Browse repository at this point
Copy the full SHA 03ff785View commit details -
Configuration menu - View commit details
-
Copy full SHA for f91cdec - Browse repository at this point
Copy the full SHA f91cdecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a54933 - Browse repository at this point
Copy the full SHA 5a54933View commit details -
fix: docs for dynamic routing in next 15 (#71531)
### What? Fixes the `params` prop in https://nextjs.org/docs/canary/app/building-your-application/routing/dynamic-routes Also fixes a typo: `synchronoulsy` -> `synchronously` ### Why? There is a breaking change in `next@15.0.0-rc.1`: https://nextjs.org/blog/next-15-rc2#async-request-apis-breaking-change Although the api docs have been updated, these have not been. ### How? updates the docs. (relevant) build and lint passes locally. ran the prettier fix. --------- Co-authored-by: JJ Kasper <jj@jjsweb.site>
1Configuration menu - View commit details
-
Copy full SHA for 96d6a96 - Browse repository at this point
Copy the full SHA 96d6a96View commit details -
[Docs] Remove the 'new' keyword from the GET function sample code. (#…
…71671) The json() method returns a Response object, so remove the new keyword. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Co-authored-by: JJ Kasper <jj@jjsweb.site>
Configuration menu - View commit details
-
Copy full SHA for 5abd117 - Browse repository at this point
Copy the full SHA 5abd117View commit details -
chore: fix wrong path of comments (#71682)
## Description At #44405, many files moved. Then sync comment paths. Co-authored-by: JJ Kasper <jj@jjsweb.site>
Configuration menu - View commit details
-
Copy full SHA for 4292752 - Browse repository at this point
Copy the full SHA 4292752View commit details -
[dynamicIO] complete refactor to prerender (#71687)
In the initial change to adopt prerender for SSR for dynamicIO I missed an instance of renderToReadableStream. This completes the work
Configuration menu - View commit details
-
Copy full SHA for d61d631 - Browse repository at this point
Copy the full SHA d61d631View commit details -
docs(next-config): remove mention of appIsrStatus is on canary (#71695)
## Why? [`appIsrStatus`](https://nextjs.org/docs/canary/app/api-reference/next-config-js/devIndicators#appisrstatus-static-indicator) is stable now, so this note is no longer necessary.
Configuration menu - View commit details
-
Copy full SHA for c1cfee3 - Browse repository at this point
Copy the full SHA c1cfee3View commit details -
fix: metadata image route normalize path posix for windows (#71673)
Configuration menu - View commit details
-
Copy full SHA for 9fac077 - Browse repository at this point
Copy the full SHA 9fac077View commit details -
next-codemod(upgrade): optional catch when missing dev script (#71598)
### Why? During the next-codemod upgrade, when the `dev` script is missing, it throws while reading `.includes` the undefined value. Fixes #71597 --------- Co-authored-by: Jiwon Choi <devjiwonchoi@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e9b18d6 - Browse repository at this point
Copy the full SHA e9b18d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51d6e76 - Browse repository at this point
Copy the full SHA 51d6e76View commit details -
fix: exclude
basePath
infindSourceMapURL
(#71719)This PR fixes #71706. When having an error client side and there is a `basePath` defined, the basePath is being used to locate the sourcemap of the given file which results in an error. With these changes the `basePath` gets removed from the `filename` passed to `findSourceMapURL` If you have questions, feel free to ask!
Configuration menu - View commit details
-
Copy full SHA for ca559a5 - Browse repository at this point
Copy the full SHA ca559a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3643c8b - Browse repository at this point
Copy the full SHA 3643c8bView commit details -
react-sync: Ignore update notices from npm (#71717)
`npm view` prints a notice when a new update is available to `stderr` tricking us into thinking there was an error. ``` npm notice npm notice New minor version of npm available! 10.7.0 -> 10.9.0 npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.9.0 npm notice To update run: npm install -g npm@10.9.0 npm notice ``` Running with `--silent` avoids these unrelated warnings (see npm/npm#2040 (comment)). ## Test plan #71718
Configuration menu - View commit details
-
Copy full SHA for b08f755 - Browse repository at this point
Copy the full SHA b08f755View commit details -
Configuration menu - View commit details
-
Copy full SHA for aed6c4c - Browse repository at this point
Copy the full SHA aed6c4cView commit details -
next-codemod: add empty
pnpm-workspace.yaml
to test fixtures to byp……ass PNPM workspace checks (#71726) ### Why? Since dep installation within next-codemod runs `pnpm install` on the Next.js repo, it installs in the workspace root scope during testing. We could add a layer for testing like adding a flag `--no-workspace`, but it will reduce confidence between the actual running and testing. Therefore added an empty `pnpm-workspace.yaml` file to each fixture. ### How? By doing this, both installation and testing will have same environment of running, `pnpm install` only. To prevent created `pnpm-lockfile` to be shipped, gitignored it. This way, we keep things simple and make sure tests match real-world use better. The empty `pnpm-workspace.yaml` files make `pnpm` treat each fixture separately, which is closer to how it'll work for users.
Configuration menu - View commit details
-
Copy full SHA for 741f830 - Browse repository at this point
Copy the full SHA 741f830View commit details -
warn on sync access if dynamicIO is not enabled (#71696)
Since `console.error` is intercepted, this can be frustrating when a 3p library that hasn't updated to use the async APIs triggers a warning. This keeps the error behavior when `dynamicIO` is enabled and warns in other cases.
Configuration menu - View commit details
-
Copy full SHA for bbad635 - Browse repository at this point
Copy the full SHA bbad635View commit details -
2
Configuration menu - View commit details
-
Copy full SHA for 40790d8 - Browse repository at this point
Copy the full SHA 40790d8View commit details -
Docs: Update default marker for fetch cache option (#71728)
This page was showing the outdated default. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
Configuration menu - View commit details
-
Copy full SHA for 4835be1 - Browse repository at this point
Copy the full SHA 4835be1View commit details -
[docs] Fix page.tsx parameter types (#71680)
Closes #71679 Co-authored-by: Zack Tanner <1939140+ztanner@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for e1632cc - Browse repository at this point
Copy the full SHA e1632ccView commit details -
[docs] Fix table.js containing TS code (#71677)
Closes #71675. Co-authored-by: Zack Tanner <1939140+ztanner@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 465d1bb - Browse repository at this point
Copy the full SHA 465d1bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for babc6a0 - Browse repository at this point
Copy the full SHA babc6a0View commit details -
next-upgrade: do not add
--turbopack
flag when--turbo
exists in ……`next dev` (#71730) ### Why? 1. When `next dev --turbo` existed, it added `--turbopack` since it was looking for existing `--turbopack` only. 2. When there's no `"dev"` script found in package.json, inform the user we weren't able to enable Turbopack for them. - https://github.com/vercel/next.js/releases/tag/v15.0.1-canary.3 ## Test Plan ### Suggest Turbopack ``` pnpm test:upgrade-fixture bin/__testfixtures__/suggest-turbopack ``` ```diff "scripts": { - "dev": "next dev" + "dev": "next dev --turbopack" }, ``` ### Change `--turbo` to `--turbopack` ``` pnpm test:upgrade-fixture bin/__testfixtures__/change-turbo-to-turbopack ``` CLI output includes: ``` ✔ Replaced "--turbo" with "--turbopack" in your dev script. ``` ```diff "scripts": { - "dev": "next dev --turbo" + "dev": "next dev --turbopack" }, ```
Configuration menu - View commit details
-
Copy full SHA for 6fba7b2 - Browse repository at this point
Copy the full SHA 6fba7b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 064970e - Browse repository at this point
Copy the full SHA 064970eView commit details -
[dynamicIO] update data access error and documentation (#71738)
It will be quite common to attempt to access data during prerendering and encounter the error that indicates you did not provide a Suspense boundary to define fallback UI. This change updates the error message and includes a link to a new docs page which explains how to handle this error. --------- Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 3a39a20 - Browse repository at this point
Copy the full SHA 3a39a20View commit details -
docs(ppr): update note about ppr (#71697)
## Why? Let's clarify this is only available in canary. We need to remove it from the stable docs later.
Configuration menu - View commit details
-
Copy full SHA for b3d7335 - Browse repository at this point
Copy the full SHA b3d7335View commit details -
Configuration menu - View commit details
-
Copy full SHA for 544d98b - Browse repository at this point
Copy the full SHA 544d98bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1cb70c4 - Browse repository at this point
Copy the full SHA 1cb70c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c464672 - Browse repository at this point
Copy the full SHA c464672View commit details -
Configuration menu - View commit details
-
Copy full SHA for 627a5ff - Browse repository at this point
Copy the full SHA 627a5ffView commit details -
Fix race condition when setting client reference manifests (#71741)
Similar to how #71669 fixed a race condition when setting the manifests singleton regarding the server action manifests, this PR fixes the same race condition for the client reference manifests.
Configuration menu - View commit details
-
Copy full SHA for 3265c95 - Browse repository at this point
Copy the full SHA 3265c95View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for f06906a - Browse repository at this point
Copy the full SHA f06906aView commit details -
Fix docs for configuring Turbopack (#71755)
### What? Fixes code examples for configuring Turbopack. Turbopack Dev is stable, but we're keeping the configuration options under `experimental` until Turbopack Build is stable as well. Most of these options will not change, but we didn't want a combination of experimental and stable options. Closes PACK-3324
Configuration menu - View commit details
-
Copy full SHA for 82196b8 - Browse repository at this point
Copy the full SHA 82196b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for dca6516 - Browse repository at this point
Copy the full SHA dca6516View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54768ac - Browse repository at this point
Copy the full SHA 54768acView commit details -
[dynamicIO] unify cache filling and lazy-module warming (#71749)
We ended up with up to three prerender passes as we added support for new use cases like lazy module initializaiton. This update refactors the PPR pathway to have at most two renders. I will follow up with a refactor of the non-ppr pathway next.
Configuration menu - View commit details
-
Copy full SHA for ab32cca - Browse repository at this point
Copy the full SHA ab32ccaView commit details -
Don't filter out <anonymous> source location frames through RSC (#71752)
This lets us show Server Components (and Host Components) in the Parent Stack passed to errors. <img width="1039" alt="Screenshot 2024-10-23 at 12 51 10 PM" src="https://github.com/user-attachments/assets/5912e750-b544-403d-8d5a-bce91c01b3a8">
Configuration menu - View commit details
-
Copy full SHA for 53f2193 - Browse repository at this point
Copy the full SHA 53f2193View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d61b88 - Browse repository at this point
Copy the full SHA 8d61b88View commit details -
Configuration menu - View commit details
-
Copy full SHA for e54338a - Browse repository at this point
Copy the full SHA e54338aView commit details -
2
Configuration menu - View commit details
-
Copy full SHA for 4bc32c3 - Browse repository at this point
Copy the full SHA 4bc32c3View commit details -
Upgrade React from
28668d39-20241023
to1631855f-20241023
(#71769)**breaking change for canary users: Bumps peer dependency of React from `19.0.0-rc-28668d39-20241023` to `19.0.0-rc-1631855f-20241023`** [diff facebook/react@28668d39...1631855f](facebook/react@28668d3...1631855) <details> <summary>React upstream changes</summary> - facebook/react#31340 </details>
Configuration menu - View commit details
-
Copy full SHA for 4ae3fc3 - Browse repository at this point
Copy the full SHA 4ae3fc3View commit details
Commits on Oct 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dbc9452 - Browse repository at this point
Copy the full SHA dbc9452View commit details -
feat: add experiment for sharpjs cpu flags (#71733)
This PR adds two experimental flags to configure sharpjs settings that may improve cpu for image optimization.
Configuration menu - View commit details
-
Copy full SHA for 0dce6bb - Browse repository at this point
Copy the full SHA 0dce6bbView commit details -
fix: handle server component replay error in error overlay (#71772)
### What When there's a replay console error showed up, display it in error overlay. #### Server Component Page <img width="480" alt="image" src="https://github.com/user-attachments/assets/7af65809-1e0e-4aa0-bffb-bc95a376fb02"> #### Server Component Page with Client Components <img width="480" alt="image" src="https://github.com/user-attachments/assets/1f8bd507-3e0f-43f3-9240-07c4aec16ab4"> --------- Co-authored-by: Sebastian Markbage <sebastian@calyptus.eu>
Configuration menu - View commit details
-
Copy full SHA for ab1d9ee - Browse repository at this point
Copy the full SHA ab1d9eeView commit details -
Don't error asking for prebuilt bundles (#71778)
Turbopack doesn't recognize webpack:// and so errors otherwise. We don't need source maps for internals. <img width="774" alt="Screenshot 2024-10-23 at 10 13 02 PM" src="https://github.com/user-attachments/assets/72ec2ecc-7fbb-4a2a-9978-8d8c365ab966">
Configuration menu - View commit details
-
Copy full SHA for f5e5107 - Browse repository at this point
Copy the full SHA f5e5107View commit details -
Replace
turbopack://[project]/...
sourcemap uris withfile://...
……in development (#71489) This makes working with devtools more straightforward, reduces our own overhead when tracing stack frames in the error overlay, etc. Generated code from Turbopack or Next.js still use `turbopack://[turbopack]` or `turbopack://[next]` respectively. Test Plan: - [x] Update tests - [x] CI - [x] https://github.com/vercel/next.js/blob/475bdb1f743bf0b3552b40f85b615d87f4ae4904/test/development/app-dir/source-mapping/README.md --------- Co-authored-by: Benjamin Woodruff <benjamin.woodruff@vercel.com> Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
Configuration menu - View commit details
-
Copy full SHA for 2a10d55 - Browse repository at this point
Copy the full SHA 2a10d55View commit details -
misc: update source map paths for bundled Next.js runtime (#71779)
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> This changes the generated source map to not do the "webpack://next/dist/<file>" and instead use the relative path. this allows us to use the vanilla ignoreList "node_modules" config to also also ignore those files  
Configuration menu - View commit details
-
Copy full SHA for a19b952 - Browse repository at this point
Copy the full SHA a19b952View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 9d1cf5e - Browse repository at this point
Copy the full SHA 9d1cf5eView commit details -
[dynamicIO] refine error message and docs (#71781)
refines the error message for non-prerenderable holes while prerendering as well as the docs
1Configuration menu - View commit details
-
Copy full SHA for 17f4291 - Browse repository at this point
Copy the full SHA 17f4291View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v15.0.1...2e28c965279de90ce4bfca673196c27dd6117027