Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source maps are generated incorrectly and cannot be debugged in vscode. #1121

Closed
axuj opened this issue Oct 11, 2023 · 2 comments · Fixed by #1122
Closed

Source maps are generated incorrectly and cannot be debugged in vscode. #1121

axuj opened this issue Oct 11, 2023 · 2 comments · Fixed by #1122
Labels
released

Comments

@axuj
Copy link
Contributor

axuj commented Oct 11, 2023

I want to debug code with breakpoints in vscode. vscode doesn't recognize breakpoints after generating a .map file with ncc build ./src/index.ts -o dist --source-map --no-source-map-register . Looking at the .map file, the sources option in there is

"sources":["../webpack://typescript/webpack/bootstrap","../webpack://typescript/./index.ts"]

manually change to

"sources":["../webpack/bootstrap","../index.ts"],

and then vscode can debug at breakpoints.

Looking at the commit history, the sources entries for .map files generated before c7b461c are correct
@styfle
Copy link
Member

styfle commented Oct 11, 2023

This sounds like a duplicate of #1011

@styfle styfle mentioned this issue Oct 12, 2023
Merged
styfle pushed a commit that referenced this issue Oct 18, 2023
@axuj
fix: sourcemap sources removes webpack path (#1122)
ce5984e 
- Fixes #1011 
- Fixes #1121 

The source is now in the format `webpack://[namespace]/[resourcePath]`
@github-actions
Copy link

🎉 This issue has been resolved in version 0.38.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ms-bot ms-bot mentioned this issue Oct 23, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: sourcemap sources removes webpack path
2 participants
@styfle @axuj