feat: add support for TypeScript 5.0's array extends in tsconfig #1105

smorimoto · 2023-08-25T10:27:43Z

add support for TypeScript 5.0's array extends in tsconfig
drop support for Node.js 14
remove tests for Tensorflow
update most dependencies

orca-security-us

Orca Security Scan Summary

Status	Check	Issues by priority
Passed	Secrets	0 0 0 0	View in Orca

smorimoto · 2023-08-25T15:32:57Z

~~Since some dependencies had to be updated, I updated all dependencies directly linked to ncc to the latest version and then confirmed that all tests passed.~~

smorimoto · 2023-08-25T15:33:50Z

package.json

    "the-answer": "^1.0.0",
    "tiny-json-http": "^7.0.2",
-    "ts-loader": "^9.3.0",
-    "tsconfig-paths": "^3.7.0",


dividab/tsconfig-paths#245

styfle

Thanks! Can you add a test to confirm the new behavior works as expected?

…llable Signed-off-by: Sora Morimoto <sora@morimoto.io>

Signed-off-by: Sora Morimoto <sora@morimoto.io>

smorimoto · 2023-08-28T18:54:38Z

@styfle Done!

smorimoto · 2023-08-28T18:56:25Z

To keep the amount of change to minimum, unrelated package updates were reverted. Let's do it with another PR as needed.

smorimoto · 2023-08-30T18:20:54Z

test/unit/tsconfig-paths-array-extends/tsconfig.json

@@ -0,0 +1,8 @@
+{
+	"extends": ["./tsconfig.a.json", "./tsconfig.b.json"],


Path to base configuration file to inherit from (requires TypeScript version 2.1 or later), or array of base files, with the rightmost files having the greater priority (requires TypeScript version 5.0 or later).

That is, the priorities are:

tsconfig.json

tsconfig.b.json

tsconfig.a.json

This test verifies that the override of the allowJs property and the combination of A and B are working as expected.

smorimoto · 2023-08-30T18:21:35Z

@styfle Could you check this?

.github/workflows/ci.yml

styfle · 2023-08-30T18:43:27Z

Looks great, thanks! Running CI now :spinner2:

Signed-off-by: Sora Morimoto <sora@morimoto.io>

smorimoto · 2023-08-31T15:22:01Z

@styfle The latest commits should also fix issues (not directly related to this PR!) related to native builds. I squashed the commit you added and put you in as a co-author.

smorimoto · 2023-08-31T15:24:00Z

@styfle Additionally, branch protection appears to be enabled for the already-removed Node.js 14. Don't forget to update that as well!

smorimoto · 2023-09-02T18:14:48Z

@styfle Could you kick the CI?

styfle · 2023-09-02T18:39:27Z

Running CI again…

smorimoto · 2023-09-02T19:31:08Z

Oh... Windows is always a nightmare...

smorimoto · 2023-09-03T16:52:12Z

@styfle One last poke...

smorimoto · 2023-09-04T19:30:46Z

I think you should definitely update this configuration...

smorimoto · 2023-09-05T00:45:59Z

@styfle I temporarily removed tfjs from the test as it was too unstable to break on other platforms when I fixed it for either platform. We can come back here again when it's correct in upstream.

Signed-off-by: Sora Morimoto <sora@morimoto.io> Co-authored-by: Steven <steven@ceriously.com>

Signed-off-by: Sora Morimoto <sora@morimoto.io>

…gyp` Signed-off-by: Sora Morimoto <sora@morimoto.io>

Signed-off-by: Sora Morimoto <sora@morimoto.io>

smorimoto · 2023-09-05T01:02:04Z

@styfle Finally, all the tests are expected to pass, and that can be confirmed here. Now all we have to do is make sure the CI is OK here and go ahead.

styfle · 2023-09-05T23:30:52Z

.github/workflows/ci.yml

    - name: Use Node.js ${{ matrix.node }}
      uses: actions/setup-node@v3
      with:
        cache: yarn
        node-version: ${{ matrix.node }}
        check-latest: true
    - name: Install Dependencies
-      run: yarn install
+      run: yarn global add node-gyp && yarn install --frozen-lockfile


Why does node-gyp need to be a global?

This might be confusing for contributors since most people do not have node-gyp installed globally.

Can we add it as a devDependency instead?

It's already listed there, but somehow it seems that Windows sometimes needs it in a global environment. I haven't investigated whether this is a problem with the package manager resolver or some kind of implementation, but generally there shouldn't be a major problem

styfle · 2023-09-05T23:37:33Z

Please update the PR description with example usage and link any existing issue, thanks!

styfle

Thanks!

github-actions · 2023-09-06T14:49:53Z

🎉 This PR is included in version 0.37.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

smorimoto · 2023-09-06T18:51:20Z

@styfle Whoa! Thank you for taking care of the rest of the work!

orca-security-us bot reviewed Aug 25, 2023

View reviewed changes

smorimoto force-pushed the typescript-5 branch from 8723fe2 to 84e2616 Compare August 25, 2023 10:30

smorimoto changed the title ~~Add support for TypeScript 5.0's array extends in tsconfig~~ feat: add support for TypeScript 5.0's array extends in tsconfig Aug 25, 2023

smorimoto marked this pull request as ready for review August 25, 2023 15:00

smorimoto requested review from styfle and Timer as code owners August 25, 2023 15:00

smorimoto force-pushed the typescript-5 branch from 84e2616 to 7195193 Compare August 25, 2023 15:28

smorimoto commented Aug 25, 2023

View reviewed changes

styfle reviewed Aug 25, 2023

View reviewed changes

smorimoto added 2 commits August 29, 2023 03:00

chore(deps): update the oracledb package to make dependencies insta…

197dee8

…llable Signed-off-by: Sora Morimoto <sora@morimoto.io>

feat: add support for TypeScript 5.0's array extends in tsconfig

604606a

Signed-off-by: Sora Morimoto <sora@morimoto.io>

smorimoto force-pushed the typescript-5 branch 2 times, most recently from aa53d9e to 78c35df Compare August 28, 2023 18:54

smorimoto commented Aug 30, 2023

View reviewed changes

styfle reviewed Aug 30, 2023

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

chore: polish update-fixtures.sh

472050b

Signed-off-by: Sora Morimoto <sora@morimoto.io>

smorimoto force-pushed the typescript-5 branch 2 times, most recently from 76b7810 to a175fc1 Compare August 31, 2023 15:17

smorimoto force-pushed the typescript-5 branch 10 times, most recently from c434d1b to 3a5b299 Compare September 5, 2023 00:43

smorimoto and others added 6 commits September 5, 2023 09:49

ci: replace node.js 14 and 20 in ci matrix

179fcc6

Signed-off-by: Sora Morimoto <sora@morimoto.io> Co-authored-by: Steven <steven@ceriously.com>

chore: update dependency versions in the safe range

95d8861

Signed-off-by: Sora Morimoto <sora@morimoto.io>

ci: make sure current Python is installed on all platforms for `node-…

38cf44e

…gyp` Signed-off-by: Sora Morimoto <sora@morimoto.io>

ci: update actions/checkout to v4

923ad9a

Signed-off-by: Sora Morimoto <sora@morimoto.io>

test: remove test for tfjs as too flaky

f6c2e5e

Signed-off-by: Sora Morimoto <sora@morimoto.io>

ci: install node-gyp globally on CI

637c285

Signed-off-by: Sora Morimoto <sora@morimoto.io>

smorimoto force-pushed the typescript-5 branch from 3a5b299 to d6557c7 Compare September 5, 2023 00:50

smorimoto force-pushed the typescript-5 branch from d6557c7 to 637c285 Compare September 5, 2023 01:02

styfle reviewed Sep 5, 2023

View reviewed changes

styfle approved these changes Sep 6, 2023

View reviewed changes

styfle merged commit f898f8e into vercel:main Sep 6, 2023
19 checks passed

github-actions bot added the released label Sep 6, 2023

smorimoto deleted the typescript-5 branch September 6, 2023 18:50

ms-bot mentioned this pull request Oct 23, 2023

chore(deps): bump 🧳 @vercel/ncc to ^0.38.1 mobsuccess-devops/pmd-github-action#12

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support for TypeScript 5.0's array extends in tsconfig #1105

feat: add support for TypeScript 5.0's array extends in tsconfig #1105

smorimoto commented Aug 25, 2023 •

edited by styfle

orca-security-us bot left a comment

smorimoto commented Aug 25, 2023 •

edited

smorimoto Aug 25, 2023

styfle left a comment

smorimoto commented Aug 28, 2023

smorimoto commented Aug 28, 2023

smorimoto Aug 30, 2023

smorimoto commented Aug 30, 2023

styfle commented Aug 30, 2023

smorimoto commented Aug 31, 2023

smorimoto commented Aug 31, 2023

smorimoto commented Sep 2, 2023

styfle commented Sep 2, 2023

smorimoto commented Sep 2, 2023

smorimoto commented Sep 3, 2023

smorimoto commented Sep 4, 2023

smorimoto commented Sep 5, 2023

smorimoto commented Sep 5, 2023

styfle Sep 5, 2023 •

edited

smorimoto Sep 6, 2023

styfle commented Sep 5, 2023

styfle left a comment

github-actions bot commented Sep 6, 2023

smorimoto commented Sep 6, 2023

		@@ -0,0 +1,8 @@
		{
		"extends": ["./tsconfig.a.json", "./tsconfig.b.json"],

feat: add support for TypeScript 5.0's array extends in tsconfig #1105

feat: add support for TypeScript 5.0's array extends in tsconfig #1105

Conversation

smorimoto commented Aug 25, 2023 • edited by styfle

orca-security-us bot left a comment

Choose a reason for hiding this comment

Orca Security Scan Summary

smorimoto commented Aug 25, 2023 • edited

smorimoto Aug 25, 2023

Choose a reason for hiding this comment

styfle left a comment

Choose a reason for hiding this comment

smorimoto commented Aug 28, 2023

smorimoto commented Aug 28, 2023

smorimoto Aug 30, 2023

Choose a reason for hiding this comment

smorimoto commented Aug 30, 2023

styfle commented Aug 30, 2023

smorimoto commented Aug 31, 2023

smorimoto commented Aug 31, 2023

smorimoto commented Sep 2, 2023

styfle commented Sep 2, 2023

smorimoto commented Sep 2, 2023

smorimoto commented Sep 3, 2023

smorimoto commented Sep 4, 2023

smorimoto commented Sep 5, 2023

smorimoto commented Sep 5, 2023

styfle Sep 5, 2023 • edited

Choose a reason for hiding this comment

smorimoto Sep 6, 2023

Choose a reason for hiding this comment

styfle commented Sep 5, 2023

styfle left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 6, 2023

smorimoto commented Sep 6, 2023

smorimoto commented Aug 25, 2023 •

edited by styfle

smorimoto commented Aug 25, 2023 •

edited

styfle Sep 5, 2023 •

edited