Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (provider/cohere): Use Cohere v2 API. #3420

Merged
merged 5 commits into from
Nov 2, 2024
Merged

feat (provider/cohere): Use Cohere v2 API. #3420

merged 5 commits into from
Nov 2, 2024
+645 −696

Conversation

shaper
Copy link
Contributor

@shaper shaper commented Oct 30, 2024 •
edited
Loading

Work items:

  • streaming
  • tool use
  • review tests
  • update docs

Resolves #3331

Sorry, something went wrong.

@shaper
feat (provider/cohere): Use Cohere v2 API.
Loading
Loading status checks…
cc859e1
@shaper shaper changed the title WIP: feat (provider/cohere): Use Cohere v2 API. feat (provider/cohere): Use Cohere v2 API. Nov 1, 2024
@shaper
Copy link
Contributor Author

shaper commented Nov 1, 2024

PTAL. I am still looking at the cohere-chatbot-with-tools.ts example which breaks due to tool_calls in an assistant message in what appears to be a schema-incompatible spot, but if there is a fix needed there we can land it in a separate PR IMO.

@lgrammel
add changeset
Loading
Loading status checks…
ecfab19
@lgrammel
add test
Loading
Loading status checks…
4293116
@lgrammel
update test
Loading
Loading status checks…
4b93cd8
lgrammel
lgrammel approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@lgrammel lgrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls update / activate stream tests

@shaper
Fix streaming tests.
Loading
Loading status checks…
bd93b46
@shaper shaper merged commit a7cbdf6 into main Nov 2, 2024
8 checks passed
@shaper shaper deleted the exp/cohere-v2 branch November 2, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgrammel lgrammel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Cohere v2 API
2 participants
@shaper @lgrammel