Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable preloading for Twitter videos #148

Conversation

dmeijboom
Copy link

When the preload attribute of the video element is set to metadata most browsers (if not all) will buffer the video anyway. In our application this results in huge data usage as we have multiple twitter embeds on the same page.

With preload set to none this doesn't happen.

Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-tweet-create-react-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 1:11pm
react-tweet-custom-tweet-dub ❌ Failed (Inspect) Dec 5, 2023 1:11pm
react-tweet-next-app ❌ Failed (Inspect) Dec 5, 2023 1:11pm
react-tweet-site ❌ Failed (Inspect) Dec 5, 2023 1:11pm
react-tweet-vite-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 1:11pm

Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

lfades added a commit that referenced this pull request Apr 8, 2024
@lfades
Copy link
Member

lfades commented Apr 8, 2024

I couldn't merge the PR because I can't update it and there are conflicts due to changes in pnpm-lock so I've pushed the change in 649fb05

@lfades lfades closed this Apr 8, 2024
@dmeijboom dmeijboom deleted the fix/disable-preloading-for-twitter-videos branch April 8, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants