Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify code: decrease one level of indentation #659

Merged
merged 1 commit into from Jun 28, 2023

Conversation

alexandear
Copy link
Contributor

Description

This PR simplifies RootApp.Run function by removing else clause.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Version of Golang used when building/testing:

  • 1.11
  • 1.12
  • 1.13
  • 1.14
  • 1.15
  • 1.16
  • 1.17
  • 1.18
  • 1.19
  • 1.20

How Has This Been Tested?

Run go test ./...

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage: 60.82474% and no project coverage change.

Comparison is base (97cd18b) 76.54039% compared to head (c02f74e) 76.54039%.

Additional details and impacted files
@@              Coverage Diff              @@
##              master        #659   +/-   ##
=============================================
  Coverage   76.54039%   76.54039%           
=============================================
  Files              8           8           
  Lines           2191        2191           
=============================================
  Hits            1677        1677           
  Misses           378         378           
  Partials         136         136           
Impacted Files Coverage Δ
cmd/mockery.go 62.16216% <60.82474%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LandonTClipp
Copy link
Contributor

Thank you!

@LandonTClipp LandonTClipp merged commit 064d477 into vektra:master Jun 28, 2023
5 checks passed
@alexandear alexandear deleted the cmd-mockery-refactor-else branch June 28, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants