Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move build tools to a separate module #612

Merged
merged 1 commit into from Apr 25, 2023

Conversation

haines
Copy link
Contributor

@haines haines commented Apr 25, 2023

Description

Adding build tools (golangci-lint in particular) to the module dependencies introduces a large number of transitive dependencies to any module that depends on mockery.

This PR splits the tools into a separate module, preventing them from becoming transitive dependencies, and introduces a workspace to manage the modules.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Version of Golang used when building/testing:

  • 1.11
  • 1.12
  • 1.13
  • 1.14
  • 1.15
  • 1.16
  • 1.17
  • 1.18
  • 1.19
  • 1.20

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

go mod download -x
go run github.com/go-task/task/v3/cmd/task test.ci

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas N/A
  • I have made corresponding changes to the documentation N/A
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works N/A
  • New and existing unit tests pass locally with my changes

Signed-off-by: Andrew Haines <andrew@haines.org.nz>
@LandonTClipp
Copy link
Contributor

This is a good solution, I'll merge once the checks succeed. Thanks!

@LandonTClipp LandonTClipp merged commit 5fabc1d into vektra:master Apr 25, 2023
3 checks passed
@haines haines deleted the separate-module-for-build-tools branch April 25, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants