Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop config search disabled message #602

Merged
merged 1 commit into from Apr 17, 2023

Conversation

connyay
Copy link
Contributor

@connyay connyay commented Apr 17, 2023

This message happens before cli parsing so its not possible to suppress the output via --log-level

This message is not useful

Description

Drops the message moved to debug log in #583

I have kind of a unique usecase of wrapping mockery in bazel in a large monorepo. Our usage doesn't require a config file but this log message is logged very frequently in our build even with --log-level error

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Version of Golang used when building/testing:

  • 1.11
  • 1.12
  • 1.13
  • 1.14
  • 1.15
  • 1.16
  • 1.17
  • 1.18
  • 1.19
  • 1.20

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This message happens before cli parsing so its not possible
to suppress the output via --log-level

This message is not useful
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.39967 ⚠️

Comparison is base (e63962d) 75.69742% compared to head (d5c95e1) 74.29775%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master        #602         +/-   ##
===================================================
- Coverage   75.69742%   74.29775%   -1.39968%     
===================================================
  Files              7           7                 
  Lines           1864        2136        +272     
===================================================
+ Hits            1411        1587        +176     
- Misses           362         421         +59     
- Partials          91         128         +37     
Impacted Files Coverage Δ
cmd/mockery.go 62.65060% <ø> (-0.90363%) ⬇️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LandonTClipp
Copy link
Contributor

Yeah, logging is hard to do properly before it's been properly instantiated. I'm fine with removing this.

@LandonTClipp LandonTClipp merged commit a1cd1d3 into vektra:master Apr 17, 2023
4 of 5 checks passed
@connyay connyay deleted the cjh-drop-message branch April 17, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants