Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Makefile with taskfile #599

Merged
merged 1 commit into from Apr 13, 2023
Merged

Replace Makefile with taskfile #599

merged 1 commit into from Apr 13, 2023

Conversation

LandonTClipp
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

  • Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Version of Golang used when building/testing:

  • 1.11
  • 1.12
  • 1.13
  • 1.14
  • 1.15
  • 1.16
  • 1.17
  • 1.18
  • 1.19
  • 1.20

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3c781b9) 75.69742% compared to head (db2fb50) 75.69742%.

❗ Current head db2fb50 differs from pull request most recent head 19a23e6. Consider uploading reports for the commit 19a23e6 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##              master        #599   +/-   ##
=============================================
  Coverage   75.69742%   75.69742%           
=============================================
  Files              7           7           
  Lines           1864        1864           
=============================================
  Hits            1411        1411           
  Misses           362         362           
  Partials          91          91           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LandonTClipp LandonTClipp merged commit 7dad3a3 into vektra:master Apr 13, 2023
5 checks passed
@LandonTClipp LandonTClipp deleted the task branch April 13, 2023 15:45
@LandonTClipp LandonTClipp restored the task branch April 13, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant