Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create recursive option for packages config #595

Merged
merged 1 commit into from Apr 17, 2023
Merged

Create recursive option for packages config #595

merged 1 commit into from Apr 17, 2023

Conversation

LandonTClipp
Copy link
Contributor

@LandonTClipp LandonTClipp commented Apr 8, 2023

Description

This commit allows you to specify recursive: true for the packages
config feature. This will recursively search for all packages on-disk
so that you don't have to manually specify them in the mockery config.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Version of Golang used when building/testing:

  • 1.11
  • 1.12
  • 1.13
  • 1.14
  • 1.15
  • 1.16
  • 1.17
  • 1.18
  • 1.19
  • 1.20

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Patch coverage: 62.82895% and project coverage change: -1.36362 ⚠️

Comparison is base (7dad3a3) 75.69742% compared to head (5959e21) 74.33380%.

❗ Current head 5959e21 differs from pull request most recent head 8a6a6bb. Consider uploading reports for the commit 8a6a6bb to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master        #595         +/-   ##
===================================================
- Coverage   75.69742%   74.33380%   -1.36362%     
===================================================
  Files              7           7                 
  Lines           1864        2139        +275     
===================================================
+ Hits            1411        1590        +179     
- Misses           362         421         +59     
- Partials          91         128         +37     
Impacted Files Coverage Δ
cmd/mockery.go 62.98507% <0.00000%> (-0.56916%) ⬇️
cmd/showconfig.go 46.87500% <42.85714%> (+17.70833%) ⬆️
pkg/config/config.go 68.91616% <64.77273%> (-5.76195%) ⬇️
pkg/generator.go 92.93194% <100.00000%> (+0.07479%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

This commit allows you to specify `recursive: true` for the `packages`
config feature. This will recursively search for all packages on-disk
so that you don't have to manually specify them in the mockery config.

Fixes #594

clarify showconfig functionality

Add debug logs for generator

Fix sub-package config merging

updates

Add tests for discoverRecursivePackages

simplify test

call Initialize for test instead

fix linting issue

add test for showconfig
@LandonTClipp LandonTClipp marked this pull request as ready for review April 17, 2023 01:58
@LandonTClipp LandonTClipp merged commit 537d49d into vektra:master Apr 17, 2023
4 of 5 checks passed
@LandonTClipp LandonTClipp deleted the issue_594 branch April 17, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement recursive option for packages feature
1 participant