Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification/simplification of packages documentation #592

Merged
merged 2 commits into from Apr 6, 2023
Merged

Clarification/simplification of packages documentation #592

merged 2 commits into from Apr 6, 2023

Conversation

LandonTClipp
Copy link
Contributor

Description

Also adding some defaults to the viper config for packages

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Version of Golang used when building/testing:

  • 1.11
  • 1.12
  • 1.13
  • 1.14
  • 1.15
  • 1.16
  • 1.17
  • 1.18
  • 1.19
  • 1.20

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Also adding some defaults to the viper config for `packages`
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch coverage: 100.00000% and project coverage change: +0.04034 🎉

Comparison is base (ea28b63) 75.08108% compared to head (48a20c3) 75.12142%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master        #592         +/-   ##
===================================================
+ Coverage   75.08108%   75.12142%   +0.04034%     
===================================================
  Files              7           7                 
  Lines           1850        1853          +3     
===================================================
+ Hits            1389        1392          +3     
  Misses           371         371                 
  Partials          90          90                 
Impacted Files Coverage Δ
pkg/config/config.go 70.48458% <100.00000%> (+0.39528%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LandonTClipp LandonTClipp merged commit 5a57633 into vektra:master Apr 6, 2023
5 checks passed
@LandonTClipp LandonTClipp deleted the configuration_docs branch April 6, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify variable meanings between packages/non-packages config
1 participant