Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: GQL Proposal API fails when getting info of a UpdateSpotMarket proposal #11154

Closed
asiaznik opened this issue Apr 18, 2024 · 0 comments · Fixed by #11157
Closed

[Bug]: GQL Proposal API fails when getting info of a UpdateSpotMarket proposal #11154

asiaznik opened this issue Apr 18, 2024 · 0 comments · Fixed by #11157
Assignees
Labels
bug fe-request A list of reasonably high value API change requests from front end

Comments

@asiaznik
Copy link

Problem encountered

It's not possible to get the full data about the update spot market proposal. riskParameters fail the query.

Observed behaviour

It fails when querying with riskParameters:

{
      "message": "an internal error occurred",
      "path": [
        "proposal",
        "subProposals",
        0,
        "terms",
        "change",
        "updateSpotMarketConfiguration",
        "riskParameters"
      ]
    }

Fragment:

fragment IUpdateSpotMarket on UpdateSpotMarket {
  marketId
  updateSpotMarketConfiguration {
    instrument {
      ... on UpdateSpotInstrumentConfiguration {
        code
        name
      }
    }
    spotMetadata: metadata
    priceMonitoringParameters {
      triggers {
        horizonSecs
        probability
        auctionExtensionSecs
      }
    }
    riskParameters {
      __typename
    }
    # spotRiskParameter: riskParameters {
    #   ... on SimpleRiskModel {
    #     params {
    #       factorLong
    #       factorShort
    #     }
    #   }
    #   ... on LogNormalRiskModel {
    #     riskAversionParameter
    #     tau
    #     params {
    #       r
    #       sigma
    #       mu
    #     }
    #   }
    # }
    liquiditySLAParams {
      priceRange
      commitmentMinTimeFraction
      performanceHysteresisEpochs
      slaCompetitionFactor
    }
    liquidityFeeSettings {
      method
      feeConstant
    }
    tickSize
  }
}

Expected behaviour

It should fail and return proper data. REST API works fine.

Steps to reproduce

Run query and see it fail.

Software version

v0.76.0-preview.3

Failing test

No response

Jenkins run

No response

Configuration used

No response

Relevant log output

No response

@asiaznik asiaznik added the bug label Apr 18, 2024
@asiaznik asiaznik changed the title [Bug]: GQL Proposal API fails when getting info of a UpdateSpotProposal [Bug]: GQL Proposal API fails when getting info of a UpdateSpotMarket proposal Apr 18, 2024
@ze97286 ze97286 self-assigned this Apr 18, 2024
@vega-issues vega-issues moved this to Waiting Review in Core Kanban Apr 19, 2024
@vega-issues vega-issues moved this from Waiting Review to Approved in Core Kanban Apr 19, 2024
@JonRay15 JonRay15 added the fe-request A list of reasonably high value API change requests from front end label Apr 19, 2024
@github-project-automation github-project-automation bot moved this from Approved to Merged in Core Kanban Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fe-request A list of reasonably high value API change requests from front end
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants