Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: StopOrders sizeOverrideSetting and sizeOverrideValue values are different than submitted #11047

Closed
bglownia opened this issue Mar 29, 2024 · 1 comment · Fixed by #11048 or #11098
Assignees
Labels

Comments

@bglownia
Copy link

Problem encountered

Stop order submitted with sizeOverrideSetting SIZE_OVERRIDE_SETTING_POSITION are returned as SIZE_OVERRIDE_SETTING_UNSPECIFIED.
sizeOverrideValue is retuned as null

Transactions sent
image

Data returned from stopOrders graphql API
image

Observed behaviour

wallet accepts sizeOverrideSetting sent as string or number. Transactions send both with "sizeOverrideSetting":2 and "sizeOverrideSetting":"SIZE_OVERRIDE_SETTING_POSITION" are retuned from stopOrders API with "SIZE_OVERRIDE_SETTING_UNSPECIFIED" value.
"sizeOverrideValue" is sent as {"percentage":"1"} and returned from API as null

Expected behaviour

Stop order should be created and returned with proper sizeOverrideSetting and sizeOverrideValue

Steps to reproduce

Submit stop order with sizeOverrideSetting SIZE_OVERRIDE_SETTING_POSITION
Query stopOrders graphql API.

Software version

v0.76.0-preview.1

Failing test

No response

Jenkins run

No response

Configuration used

No response

Relevant log output

No response

@bglownia bglownia added the bug label Mar 29, 2024
@bglownia bglownia assigned ze97286 and unassigned gordsport Mar 29, 2024
@vega-issues vega-issues moved this to Waiting Review in Core Kanban Mar 29, 2024
@vega-issues vega-issues moved this from Waiting Review to In Review in Core Kanban Mar 29, 2024
@vega-issues vega-issues moved this from In Review to Approved in Core Kanban Mar 29, 2024
@vega-issues vega-issues moved this from Approved to In Review in Core Kanban Mar 29, 2024
@vega-issues vega-issues moved this from In Review to Approved in Core Kanban Mar 29, 2024
@github-project-automation github-project-automation bot moved this from Approved to Merged in Core Kanban Mar 29, 2024
@bglownia bglownia reopened this Apr 10, 2024
@bglownia
Copy link
Author

I just tested it on stagnet. This fix should be included in v0.76.0-preview.2 but it still returns sizeOverrideSetting: SIZE_OVERRIDE_SETTING_UNSPECIFIED and sizeOverrideValue:null

image

You can try submit position scoped stop order from
https://trading.4353-position-tp-sl.vega.rocks/

@vega-issues vega-issues moved this from Merged to Waiting Review in Core Kanban Apr 11, 2024
@vega-issues vega-issues moved this from Waiting Review to Approved in Core Kanban Apr 11, 2024
@vega-issues vega-issues moved this from Approved to In Review in Core Kanban Apr 11, 2024
@github-project-automation github-project-automation bot moved this from In Review to Merged in Core Kanban Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
3 participants