Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for signals in mark clip #9282

Merged
merged 4 commits into from
Mar 11, 2024
Merged

feat: add support for signals in mark clip #9282

merged 4 commits into from
Mar 11, 2024

Conversation

lsh
Copy link
Member

@lsh lsh commented Mar 11, 2024

PR Description

In Vega, mark supports a signal for the clip property. To round out the Vega-Lite API, we should support it here as well, especially since it is trivial to add.

Checklist

  • This PR is atomic (i.e., it fixes one issue at a time).
  • The title is a concise semantic commit message (e.g. "fix: correctly handle undefined properties").
  • yarn test runs successfully
  • For new features:
    • Has unit tests.
    • Has documentation under site/docs/ + examples.

Tips:

@lsh lsh requested a review from a team as a code owner March 11, 2024 20:49
@lsh lsh requested review from domoritz and kanitw March 11, 2024 20:50
src/compile/mark/mark.ts Outdated Show resolved Hide resolved
Copy link
Member

@kanitw kanitw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Have a nit to fix before merging.

@lsh lsh merged commit bf14024 into main Mar 11, 2024
9 checks passed
@lsh lsh deleted the lsh/clip-signal branch March 11, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants